1693511 - "Download the latest version" link after failed update via About Thunderbird does nothing

Status: RESOLVED FIXED

(Thunderbird :: Installer, defect)

Description

[Thomas D. (:thomas8)]

Attachment: Screenshot (OT): Daily claims to update to already current version

Seen several times on Daily, probably 87.0a1 (2021-02-17) (64-Bit) DE.
Updating Daily has become a hassle in so many ways.
From About Thunderbird, first downloads small update, then full update, then fails.
"Download the latest version" link does nothing (but works when you get it from the panel popup in 3-pane) - this bug.

OT: Today also trying to update to the same version it is already on (see screenshot).

Comment 1

[Rob Lemley [:rjl]]

Does today's update as expected? There were two Daily builds on the 17th. That explains part of your report.

The manual download link throws an error:

Uncaught ReferenceError: openURL is not defined
    onclick chrome://messenger/content/aboutDialog.xhtml:1

Comment 2

[Rob Lemley [:rjl]]

The link breaking is a casualty of multi-process link handling done in bug 1683787. openURL() came from contentAreaUtils.js (in toolkit) which was removed from aboutDialog.xhtml.

Comment 3

[Rob Lemley [:rjl]]

Attachment: Bug 1693511 - Fix manual download link in about dialog. r=darktrojan

openURL was part of contentAreaUtils.js which is no longer included since
bug 1683787. openLink from aboutdialog.js accomplishes the same.

Comment 4

[Thomas D. (:thomas8)]

Thank you very much Rob for looking into this!

Comment 5

[Rob Lemley [:rjl]]

Comment on attachment 9203969 [details]
Bug 1693511 - Fix manual download link in about dialog. r=darktrojan

[Approval Request Comment]
Regression caused by (bug #): 1683787
User impact if declined: Manual download link in about: dialog does not work
Testing completed (on c-c, etc.): tested with local build
Risk to taking this patch (and alternatives if risky):
Patch changes the button click event to call a different function that already exists in the about dialog code. Should be minimal risk to taking on beta.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/22bff738971e
Fix manual download link in about dialog. r=darktrojan

Comment 7

[Dave Miller [:justdave]]

Thunderbird 87.0b1
https://hg.mozilla.org/releases/comm-beta/rev/656b493fb6cb

Comment 8

[Dave Miller [:justdave]]

got a verbal approval-comm-beta+ from wsmwk on Matrix

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9203969 [details]
Bug 1693511 - Fix manual download link in about dialog. r=darktrojan

[Triage Comment]
(previously) approved for beta (and already shipped)