Closed
Bug 1693730
Opened 3 years ago
Closed 3 years ago
Remove duplicate definition of -profiler-brand-name in perftools.ftl
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(firefox88 fixed)
RESOLVED
FIXED
88 Branch
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: flod, Assigned: nchevobbe)
References
Details
Attachments
(1 file)
The brand name is now defined in two places:
- brandings.ftl (correct)
- perftools.ftl (duplicate)
We should load brandings.ftl instead of defining the term a second time.
I assume it's not a problem that the file in question is outside of devtools, otherwise we would have the same issue with other brand names (e.g. Firefox).
|
||
Comment 1•3 years ago
|
||
We should try to load brandings.ftl on top of perftools.ftl at https://searchfox.org/mozilla-central/rev/df23c6e58c6be1eb8399e475878f73d4867bef87/devtools/client/performance-new/aboutprofiling/initializer.js#96
Severity: -- → S3
Priority: -- → P3
|
Assignee | |
Comment 2•3 years ago
|
||
|
||
Updated•3 years ago
|
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/86374edb5ef1 [devtools] Remove duplicate definition of -profiler-brand-name in perftools.ftl. r=julienw,fluent-reviewers,flod.
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox88:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•