1693802 - Make Connection.jsm work with both CDP and WebDriver BiDi

Status: RESOLVED FIXED

(Remote Protocol :: Agent, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

With the Connection.jsm module located under cdp/ now, we should figure out how we can refactor the code to make it usable with BiDi in parallel.

Questions to solve:

• CDP and BiDi have fundamentally different concept of a session. But maybe we want to re-use the same session id?

• Shall we have a generic Connection module that can be shared between CDP and Bidi, and each of these protocols implementing their own session and command/response handling?

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Attachment: Bug 1693802 - [remote] Refactor Connection module to be used by CDP and WebDriver BiDi.

The patch extracts common code that can be re-used
by both the CDP, and the upcoming WebDriver BiDi
protocol.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e17aba743f7
[remote] Refactor Connection module to be used by CDP and WebDriver BiDi. r=webdriver-reviewers,jdescottes

Comment 3

[Dorel Luca [:dluca]]

Backed out changeset 4e17aba743f7 (bug 1693802) for XPCshell failures in chrome://remote/content/cdp/CDPConnection.jsm. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=344443974&repo=autoland&lineNumber=4998

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=4e17aba743f7d67db359eeb64934e632ce752e44

Backout:
https://hg.mozilla.org/integration/autoland/rev/476ff480c877b7d396fef6e41ba91288d6050f50

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Sadly my try build didn't include the xpcshell tests, so this hasn't been caught. Problem here is a change for the error message for splitMethod, which now includes quotes and not double quotes.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa7b561ebaba
[remote] Refactor Connection module to be used by CDP and WebDriver BiDi. r=webdriver-reviewers,jdescottes

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/aa7b561ebaba