1693997 - Switch to MailServices in compose

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Composition, task)

Description

[Ian Neal]

This will remove the use of gAccountManager/hdrParser in MsgComposeCommands.js and gMimeHeaderParser in addressingWidgetOverlay.js

Comment 1

[Ian Neal]

Attachment: 1693997-remove-gAccountManager-compose-2538.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.7
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Comment 2

[Ian Neal]

Attachment: 1693997-mailservices-compose-v1_1-2538.patch

Also remove gMimeHeaderParser from addressingWidgetOverlay.js and hdrParser from MsgComposeCommands.js

Comment 3

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9204416 [details] [diff] [review]
1693997-mailservices-compose-v1_1-2538.patch

LGTM

Line is a bit long

+ var numAddresses = MailServices.headerParser.parseHeadersWithArray(aAddressesToAdd, emailAddresses, names, fullNames);

Maybe

+ var numAddresses =
+ MailServices.headerParser.parseHeadersWithArray(aAddressesToAdd,
+ emailAddresses, name,
+ fullNames);

But r/a+ either way.

Comment 4

[Frank-Rainer Grahl (:frg)]

(In reply to Frank-Rainer Grahl (:frg) from comment #3)

Comment on attachment 9204416 [details] [diff] [review]
1693997-mailservices-compose-v1_1-2538.patch

LGTM

Line is a bit long

+ var numAddresses = MailServices.headerParser.parseHeadersWithArray(aAddressesToAdd, emailAddresses, names, fullNames);

Maybe

+ var numAddresses =
+ MailServices.headerParser.parseHeadersWithArray(aAddressesToAdd,
+ emailAddresses, name,
+ fullNames);

But r/a+ either way.

Comment 5

[Ian Neal]

Attachment: 1693997-mailservices-compose-v1_2-2538.patch

Revised as suggested.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d614605736ff
Switch to MailServices in compose. r=frg

Comment 7

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/3240d9ad2772f5a21d6047f90c7ed0684e5d48ea
Switch to MailServices in compose. r=frg a=frg