1693994 - Update subject handling and GenericSendMessage function in compose window

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Composition, enhancement)

Description

[Ian Neal]

Port to SeaMonkey the relevant parts of the following bugs:

• Bug 367698 - avoid pre-populating "(no subject)" text in subject box.
• Bug 389650 - "Unable to save your message as a draft" and "Assembling mail information" when replying to forwarded attached .eml message.
• Bug 384842 - Specially crafted subject lines (certain length, space at the end) generated invalid mail headers.

Comment 1

[Ian Neal]

Attachment: 1693994-genericsendmessage-2538.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: Chance of generating invalid headers
Testing completed (on m-c, etc.): 2.53.7
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: 4 new strings, 2 strings removed

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9204397 [details] [diff] [review]
1693994-genericsendmessage-2538.patch

LGTM

nits

+ var servertype = account.incomingServer.type;
+
+ if (servertype != "nntp" && msgCompFields.newsgroups != "") {

servertype in only used here so could be used directly. See corresponding mail file.

+ gAutoSaving = msgType == Ci.nsIMsgCompDeliverMode.AutoSaveAsDraft;

Could use brackets around the comparision for readability. See corresponding mail file.

Comment 3

[Ian Neal]

Attachment: 1693994-genericsendmessage-v1_1-2538.patch

Revised as suggested.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4c65b79798e1
Update subject handling and GenericSendMessage function in compose window. r=frg

Comment 5

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/2ac9c3b1aa8f5afafdd800bc31e791e7d1100431
Update subject handling and GenericSendMessage function in compose window. r=frg a=frg