Closed Bug 1693992 Opened 4 years ago Closed 4 years ago

Port |Bug 482080 - new message created from compose window should use the same initial identity as its parent compose window| to SeaMonkey

Categories

(SeaMonkey :: MailNews: Composition, task)

Tracking

(seamonkey2.53+ fixed, seamonkey2.57esr? affected)

RESOLVED FIXED
seamonkey 2.86
Tracking Status
seamonkey2.53 + fixed
seamonkey2.57esr ? affected

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

Details

(Whiteboard: SM2.53.8)

Attachments

(1 file)

Port to SeaMonkey the relevant parts of:

  • Bug 482080 - new message created from compose window should use the same initial identity as its parent compose window.

Also switch to using MailServices.compose in MsgComposeCommands.js

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.7
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Attachment #9204396 - Flags: review?(frgrahl)
Attachment #9204396 - Flags: approval-comm-release?
Attachment #9204396 - Flags: approval-comm-esr60?
Whiteboard: SM2.53.8
Blocks: 1693994
Blocks: 1693997
Blocks: 1628671

Comment on attachment 9204396 [details] [diff] [review]
1693992-port482080-2538.patch

LGTM

NIT typo inorder

regexp is missing the change from Bug 1138095:

  •  body = body.replace("&", "&", "g");
    
  • body = body.replace(/&/g, "&");
    

I corrected both and uploaded a version 1.1 to gitlab. Please check and I would push then unless you want to do a separate patch for the regexp.

Attachment #9204396 - Flags: review?(frgrahl)
Attachment #9204396 - Flags: review+
Attachment #9204396 - Flags: approval-comm-release?
Attachment #9204396 - Flags: approval-comm-release+
Attachment #9204396 - Flags: approval-comm-esr60?
Attachment #9204396 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/10ccf95f9741
Port |Bug 482080 - new message created from compose window should use the same initial identity as its parent compose window| to SeaMonkey. r=frg

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/b97bb10974ca27f2941e356480f5a8135e9f4ade
Port |Bug 482080 - new message created from compose window should use the same initial identity as its parent compose window| to SeaMonkey. r=frg a=frg

Target Milestone: --- → seamonkey 2.86
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: