1694739 - FOG IPC Replay

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task, P1)

Description

[Chris H-C :chutten]

Near as we can tell, all supported IPC ops in FOG metrics are correctly serializing across IPC. But then we ignore them.

Let's apply these partial products to the metric instances.

Comment 1

[Chris H-C :chutten]

Timing Distributions (bug 1695228) and Events (bug 1672198 (and also bug 1678567)) and Labeled Counters (bug 1688281) are still waiting for various levels of support (from not panicking when called on non-parent processes, to supporting testGetValue, to having the API necessary for IPC to replay data). But we have bugs for all that work.

Comment 2

[Chris H-C :chutten]

Attachment: data collection review

Comment 3

[Chris H-C :chutten]

Attachment: Bug 1694739 - FOG IPC Replay memory, string lists, and timings r?janerik!

Comment 4

[Chris H-C :chutten]

Attachment: Bug 1694739 - FOG IPC flush after 5s of idle r?janerik!

Interestingly, on my machine, it appears to be after every 5s of idle,
not just after the first 5s of idle. We may wish to tweak that.

We also instrument the size and speed of IPC as seen from the POV of the parent
process, for monitoring purposes.

Depends on D106946

Comment 5

[Nicole Shadowen]

Comment on attachment 9206397 [details]
data collection review

DATA COLLECTION REVIEW RESPONSE:

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
   This collection is documented in its metrics documentation: https://firefox-source-docs.mozilla.org/metrics/index.html

2. Is there a control mechanism that allows the user to turn the data collection on and off?
   This collection is default on. This collection can be controlled in Firefox's Preferences.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?
   Yes, this collection will be permanent. :chutten will monitor the data over time.

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
   Category 1, Technical.

5. Is the data collection request for default-on or default-off?
   Default-on.

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
   No.

7. Is the data collection covered by the existing Firefox privacy notice?
   Yes.

8. Does there need to be a check-in in the future to determine whether to renew the data?
   No.

9. Does the data collection use a third-party collection tool?
   No.

---

Result: data-review+

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a0f48229f33
FOG IPC Replay memory, string lists, and timings r=janerik
https://hg.mozilla.org/integration/autoland/rev/123143e183f9
FOG IPC flush after 5s of idle r=janerik

Comment 7

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1694739) for XPCshell failures in toolkit/components/glean/xpcshell/test_GleanIPC.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=332407331&repo=autoland&lineNumber=2008

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=123143e183f97172102f3064a8bb779689fd31c1

Backout:
https://hg.mozilla.org/integration/autoland/rev/d4fb51a7aaf74ef4d67040568b50c919118f6ec5

Comment 8

[Chris H-C :chutten]

Right! After bug 1695197 we're running these tests on Android. Gotta skipif test_GleanIPC.js

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/447f53e61452
FOG IPC Replay memory, string lists, and timings r=janerik
https://hg.mozilla.org/integration/autoland/rev/abcc9bf1e56f
FOG IPC flush after 5s of idle r=janerik

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/447f53e61452
https://hg.mozilla.org/mozilla-central/rev/abcc9bf1e56f