169484 - Minor UI Nits on Filter Log dialog

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect)

Description

[jglick]

1. Text on dialog: 
Change from: "The Filter Log is a file which documents what filters have been 
run. Use the checkbox below (to) enable logging."
To: The Filter Log documents what filters have been run. Use the checkbox below 
to enable filter logging.

2. Add mnemonic for checkbox: _E_nable the Filter Log

3. Buttons: Dialog currently just has an "OK" button. Either (1) add a "Cancel" 
button (If the user "Clears" the filter log or "Enables the filter log", can the 
actions be undone by clicking Cancel?) or (2) remove the "OK" button.

Comment 1

[laurel]

Not sure whether it might be unclear to users that the log lists activity for
that account only, that they'd need to enable logging for each account
separately... maybe a little clarification in the wording if you think it's
warranted.

Comment 2

[jglick]

The Filter Log dialog can only be opened from the Message Filters window which 
says "Filters for <accountname>". Do you think that is not clear enough?

Or, we could say: "The Filter Log documents what filters have been run for this 
account. Use the checkbox below to enable filter logging."

Comment 3

[robinf]

I agree with Jen's suggested wording.

Comment 4

[Alex Bishop]

> "The Filter Log documents what filters have been run for this 
> account. Use the checkbox below to enable filter logging."

Not "The Filter Log documents *which* filters have been run for this account" 
or just "The Filter Log documents the filters that have been run for this 
account"?

Comment 5

[robinf]

>"The Filter Log documents the filters that have been run for this 
>account"?

Yes, that's better wording, thanks. 

Comment 6

[jglick]

Just spoke to sspitzer about the "OK" button. Because the log is a Modal dialog, 
it needs a button to dismiss it. The actions can't be Undone via a "Cancel", so 
I'd recommend "Close" instead of "OK". ("OK" is used to apply changes and then 
close a dialog.)

Comment 7

[Mike Cowperthwaite]

*** Bug 203357 has been marked as a duplicate of this bug. ***

Comment 8

[Mark Banner (:standard8)]

Attachment: Proposed Patch

The "to" change was fixed by bug 204338.
The mnemonic for checkbox was fixed in the recent checkbox/radio button fixes
(sorry don't know the number).

This proposed patch changes the remaining text to that suggested in comment 5,
and changes the "OK" button to "Close". It also does it for both the Junk Mail
Log and Filter Log dialogs.

Comment 9

[[e-mail]]

Comment on attachment 161475 [details] [diff] [review]
Proposed Patch

The method used to change the button labels changed recently. Now all you need
is buttonlabelaccept and buttonaccesskeyaccept attributes on the dialog.

Comment 10

[Mark Banner (:standard8)]

Attachment: patch v2

Revised to incorporate Neil's comments.

Comment 11

[[e-mail]]

Comment on attachment 161708 [details] [diff] [review]
patch v2

Whoops, should have spotted that before, but l is a bad choice of access key
(only 1 pixel wide in some fonts) so please change it before it gets checked
in.

Comment 12

[Mark Banner (:standard8)]

Attachment: Patch v3 for checkin

Modified to change accesskey from 'l' to 'o'.

Comment 13

[Mark Banner (:standard8)]

Comment on attachment 161712 [details] [diff] [review]
Patch v3 for checkin

Copying review flag from Neils review approval, also requesting superreview.

Comment 14

[timeless]

if you need someone to check this in you can ask here or on irc. neil or someone
else should be willing.

Comment 15

[Mark Banner (:standard8)]

can anyone check this in for me please? Just add a note when you're done. Thanks.

Note: Changing OS to All as this affects all OS not just windows.

Comment 16

[[e-mail]]

Fix checked in.

Comment 17

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using build 2005-07-10-05 on Windows XP SeaMonkey trunk:

Jennifer's comment 0 point 1 (ammended with 'for this account' to cover comment
1), point 2 and point 3 are all covered now.