Closed Bug 1696042 Opened 4 years ago Closed 4 years ago

Enable Fission web-platform-tests on more platforms (Linux ASan and Windows 10 debug)

Categories

(Testing :: web-platform-tests, task, P2)

task

Tracking

(Fission Milestone:M7a, firefox-esr78 disabled, firefox86 disabled, firefox87 disabled, firefox88 disabled, firefox89 fixed)

RESOLVED FIXED
89 Branch
Fission Milestone M7a
Tracking Status
firefox-esr78 --- disabled
firefox86 --- disabled
firefox87 --- disabled
firefox88 --- disabled
firefox89 --- fixed

People

(Reporter: cpeterson, Assigned: ahal)

References

(Depends on 1 open bug, Blocks 2 open bugs)

Details

Attachments

(12 files, 1 obsolete file)

48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review

Our testing strategy and list of tests we'd like to enable on which platforms:

https://docs.google.com/document/d/19MergQfMob2mdb_s7hlz5Ilj7Bn-Bbi324r6d2bZfxw/edit

We want to run these tests on:

  • debug and opt builds
    • Where “shippable” opt builds available, we prefer to test shippable opt builds on central and plain opt builds on autoland.
  • autoland and central
  • We prefer to run tests with Fission + WebRender (“qr”) where available.

ASan and TSan are not run on all platforms.

We want to enable these WPTs on the following platforms:

  • web-platform-tests
    • linux1804-64-asan/opt
    • linux1804-64-tsan/opt
    • windows10-64-qr/debug (we’re already testing opt)
  • web-platform-tests-crashtest
    • linux1804-64-asan/opt
    • windows10-64-qr/debug (we’re already testing opt)
  • web-platform-tests-print-reftest
    • linux1804-64-asan/opt
    • windows10-64-qr/debug (we’re already testing opt)
  • web-platform-tests-reftest
    • linux1804-64-asan/opt
    • linux1804-64-tsan/opt
    • windows10-64-qr/debug (we’re already testing opt)
  • web-platform-tests-wdspec
    • linux1804-64-asan/opt
    • windows10-64-qr/debug (we’re already testing opt)
  • web-platform-tests-wdspec-headless
    • linux1804-64-qr/opt on autoland, shippable-qr opt on central
    • windows10-64-qr/opt on autoland, shippable-qr opt on central
Component: DOM: Navigation → web-platform-tests
Product: Core → Testing

James, can you please enable the additional platforms for these WPTs?

Assignee: kmadan → nobody
Flags: needinfo?(james)

https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=314f029c210e2eec270589b323424c4c24542742 is a try push with some extra platforms. Compared to the above list:

  • tsan seems too unstable (in general, not fission specific) to enable more platforms at this time
  • I can't quite tell what's going on with headless mode; there seems to be some special magic in the task configuration that prevents it being scheduled. I'll investigate further.

We can obviously update the metadata for the failures in the above try push.

James, any more info from your investigation?

Fission Milestone: M7 → M7a

Assigning remaining "Enable Fission tests on more platforms" bugs to ahal.

Assignee: nobody → ahal

This bug has been added to releng's backlog and will be picked up sometime in the next few weeks. I'll likely end up taking this, but unassigning myself for now in case someone else ends up helping out.

Assignee: ahal → nobody
Assignee: nobody → ahal
Status: NEW → ASSIGNED

This adds the following configurations on central and autoland:

test-windows10-64-qr/debug-web-platform-tests-fis-e10s

This adds the following configurations on central and autoland:

test-linux1804-64-asan/opt-web-platform-tests-fis-e10s

Depends on D110553

This enables the following configuration on central / autoland:

test-linux1804-64-tsan/opt-web-platform-tests-fis-e10s

Depends on D110554

This enables the following configuration on autoland/central:

test-linux1804-64-asan/opt-web-platform-tests-crashtest-fis-e10s

This enables the following configuration on autoland/central:

test-windows10-64-qr/debug-web-platform-tests-reftest-fis-e10s

This enables the following configuration on autoland/central:

test-linux1804-64-asan/opt-web-platform-tests-reftest-fis-e10s

Depends on D110830

Attachment #9213105 - Attachment description: WIP: Bug 1696042 - [ci] web-platform-test-crashtest: Run fission windows10-qr/debug on trunk → Bug 1696042 - [ci] web-platform-test-crashtest: Run fission windows10-qr/debug on trunk
Attachment #9213105 - Attachment description: Bug 1696042 - [ci] web-platform-test-crashtest: Run fission windows10-qr/debug on trunk → Bug 1696042 - [ci] web-platform-test-crashtest: Run fission windows10-qr/debug on trunk, r?jgraham

This enables the following configuration on autoland/central:

test-windows10-64-qr/debug-web-platform-tests-print-reftest-fis-e10s

This enables the following configuration on autoland/central:

test-linux1804-64-asan/opt-web-platform-tests-print-reftest-fis-e10s

Depends on D110836

Attachment #9213103 - Attachment description: WIP: Bug 1696042 - [ci] web-platform-test: Run fission linux64-asan/opt on autoland and mozilla-central → Bug 1696042 - [ci] web-platform-test: Run fission linux64-asan/opt on autoland and mozilla-central
Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/80e6aef40e50 [ci] web-platform-test: Run fission debug on autoland and mozilla-central, r=jgraham https://hg.mozilla.org/integration/autoland/rev/5991f2ed9496 [ci] web-platform-test: Run fission linux64-asan/opt on autoland and mozilla-central r=jgraham https://hg.mozilla.org/integration/autoland/rev/5802c0beafd1 [ci] web-platform-test-crashtest: Run fission windows10-qr/debug on trunk, r=jgraham https://hg.mozilla.org/integration/autoland/rev/a62f976a393a [ci] web-platform-test-crashtest: Run fission linux64-asan/opt on trunk, r=jgraham https://hg.mozilla.org/integration/autoland/rev/d9de90fb0b90 [ci] web-platform-test-reftest: Run fission windows10-qr/debug on trunk, r=jgraham https://hg.mozilla.org/integration/autoland/rev/c5e8ce62436d [ci] web-platform-test-reftest: Run fission linux64-asan/opt on trunk, r=jgraham https://hg.mozilla.org/integration/autoland/rev/8adbfb955b40 [ci] web-platform-test-print-reftest: Run fission windows10-qr/debug on trunk, r=jgraham https://hg.mozilla.org/integration/autoland/rev/7bd2b5fc9b37 [ci] web-platform-test-print-reftest: Run fission linux64-asan/opt on trunk, r=jgraham

This enables the following configuration on autoland/central:

test-windows10-64-qr/debug-web-platform-tests-wdspec-fis-e10s

This enables the following configuration on autoland/central:

test-linux1804-64-asan/opt-web-platform-tests-wdspec-fis-e10s

Depends on D111141

This enables the following configurations on autoland/central:

test-linux1804-64-asan/opt-web-platform-tests-wdspec-headless-e10s
test-linux1804-64-asan/opt-web-platform-tests-wdspec-headless-fis-e10s

Depends on D111142

Still some more work to do here, almost done.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

I'll do another try run in a bit, but tsan looks a bit flaky here as well. Might be common issues with the other suites, in which case it would be better to tackle all tsan tasks in a separate bug.

Flags: needinfo?(james)
Attachment #9214177 - Attachment description: WIP: Bug 1696042 - [ci] web-platform-test-wdspec-headless: Run fission windows10-qr/debug on trunk, r?jgraham → Bug 1696042 - [ci] web-platform-test-wdspec-headless: Run fission windows10-qr/debug on trunk, r?jgraham
Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6fa186aef599 [ci] web-platform-test-wdspec: Run fission windows10-qr/debug on trunk, r=jgraham https://hg.mozilla.org/integration/autoland/rev/089853a337cd [ci] web-platform-test-wdspec: Run fission linux64-asan/opt on trunk, r=jgraham https://hg.mozilla.org/integration/autoland/rev/4a56ecca58bd [ci] web-platform-test-wdspec-headless: Run fission linux64-asan/opt on trunk, r=jgraham

There was one patch left to land, but I think I'll call this done after that.

Chris, fyi there are still some issues with tsan:
https://treeherder.mozilla.org/jobs?repo=try&revision=e2487391f036693313bd60adfb1ce49516ba959f&searchStr=tsan

Probably some root causes in common with the mochitest problems. We could probably green it up through manifest annotations, but I think I'll delay doing that in favour of working on the requests in the other bugs for now.

Maybe there could be a single fission tsan bug to enable it across all the desired suites (since I suspect each suite is hitting similar problems).

Status: RESOLVED → REOPENED
Flags: needinfo?(cpeterson)
Resolution: FIXED → ---
Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/35c54fcf3396 [ci] web-platform-test-wdspec-headless: Run fission windows10-qr/debug on trunk, r=jgraham,webdriver-reviewers
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED

(In reply to Andrew Halberstadt [:ahal] from comment #25)

Chris, fyi there are still some issues with tsan:
https://treeherder.mozilla.org/jobs?repo=try&revision=e2487391f036693313bd60adfb1ce49516ba959f&searchStr=tsan

Probably some root causes in common with the mochitest problems. We could probably green it up through manifest annotations, but I think I'll delay doing that in favour of working on the requests in the other bugs for now.

Maybe there could be a single fission tsan bug to enable it across all the desired suites (since I suspect each suite is hitting similar problems).

I peeked at the tsan failures. Like the tsan failures in mochitest-plain bug 1698193, the failures are nearly all timeouts. The tsan tests are slow and Fission will make them slower. Like bug 1698193, the Fission team is not concerned about these timeouts, since they don't indicate tsan bugs. I will file a new bug to skip those tsan tests and enable the rest for Fission: bug 1706560.

Flags: needinfo?(cpeterson)
Summary: Enable Fission web-platform-tests on more platforms (Linux ASan/TSan and Windows 10 debug) → Enable Fission web-platform-tests on more platforms (Linux ASan and Windows 10 debug)
See Also: → 1706560
Depends on: 1668853

Comment on attachment 9213104 [details]
WIP: Bug 1696042 - [ci] web-platform-test: Run fission linux64-tsan on trunk

Revision D110555 was moved to bug 1706560. Setting attachment 9213104 [details] to obsolete.

Attachment #9213104 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: