Closed Bug 1696084 Opened 5 years ago Closed 5 years ago

Open help links in a new tab

Categories

(Firefox :: Address Bar, task, P1)

Product:
Firefox
Component:
Address Bar
Type:
task
Points:
2

Tracking

()

Status:
VERIFIED FIXED
Milestone:
88 Branch
Iteration:
88.1 - Feb 22 - Mar 7
Tracking Flags:
Tracking Status
firefox86 --- unaffected
firefox87 + verified
firefox88 --- verified

People

(Reporter: adw, Assigned: adw)

References

Details

Attachments

(2 files)

Bug 1696084 - Open help links in a new tab.
48 bytes, text/x-phabricator-request
Details | Review
Beta 87 patch
7.34 KB, patch
jcristau
: approval-mozilla-beta+
Details | Diff | Splinter Review

Right now help links in urlbar results load in the current tab, but they should open a new tab. I confirmed with Natalie on Slack.

[Tracking Requested - why for this release]:

We need this for the contextual services/quick suggest experiment in 87.

status-firefox87: --- → affected
status-firefox88: --- → affected
tracking-firefox87: --- → ?

Depends on D107015

Blocks: 1696232
Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/38aa4daa99a6 Open help links in a new tab. r=harry

https://hg.mozilla.org/mozilla-central/rev/38aa4daa99a6

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox88: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Attached patch Beta 87 patch — — Splinter Review

This needs a specific beta patch because the m-c one doesn't apply cleanly due to the fact that bug 1691544 is on m-c but not beta.

Like the m-c patch, this one is based on bug 1696061.

Comment on attachment 9206827 [details] [diff] [review]
Beta 87 patch

Beta/Release Uplift Approval Request

  • User impact if declined: We need this for the contextual services/quick suggest experiment in 87.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: 1. Enable quick suggest
  1. Type something in the urlbar to trigger a quick suggest result, like "galaxy"
  2. Click the ? help button the quick suggest result
  3. Verify that the help page opens in a new tab
  • List of other uplifts needed: Bug 1696061
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small patch that only changes a variable so that help links are opened in a new tab. Covered by a test.
  • String changes made/needed:
Attachment #9206827 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Flags: in-testsuite+
QA Whiteboard: [qa-triaged]

Comment on attachment 9206827 [details] [diff] [review]
Beta 87 patch

approved for 87.0b6

Attachment #9206827 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
status-firefox86: --- → unaffected

I verified this issue using Fx 88.0a1(2021-03-05) and Fx 87.0b6 on Windows 10 x64, Ubuntu 20.04 and macOS 10.13.

Status: RESOLVED → VERIFIED
status-firefox87: fixed → verified
status-firefox88: fixed → verified
Flags: qe-verify+
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: