1696084 - Open help links in a new tab

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

Right now help links in urlbar results load in the current tab, but they should open a new tab. I confirmed with Natalie on Slack.

Comment 1

[Drew Willcoxon :adw]

[Tracking Requested - why for this release]:

We need this for the contextual services/quick suggest experiment in 87.

Comment 2

[Drew Willcoxon :adw]

Attachment: Bug 1696084 - Open help links in a new tab.

Depends on D107015

Comment 3

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b6b1e73588db3014c65dbb3a7d1f9ae925f5f14

Comment 4

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d5076d05200462e13888dec5f83deccd3cd045d6

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/38aa4daa99a6
Open help links in a new tab. r=harry

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/38aa4daa99a6

Comment 7

[Drew Willcoxon :adw]

Attachment: Beta 87 patch

This needs a specific beta patch because the m-c one doesn't apply cleanly due to the fact that bug 1691544 is on m-c but not beta.

Like the m-c patch, this one is based on bug 1696061.

Comment 8

[Drew Willcoxon :adw]

Comment on attachment 9206827 [details] [diff] [review]
Beta 87 patch

Beta/Release Uplift Approval Request

• User impact if declined: We need this for the contextual services/quick suggest experiment in 87.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Enable quick suggest

2. Type something in the urlbar to trigger a quick suggest result, like "galaxy"
3. Click the ? help button the quick suggest result
4. Verify that the help page opens in a new tab

• List of other uplifts needed: Bug 1696061
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small patch that only changes a variable so that help links are opened in a new tab. Covered by a test.
• String changes made/needed:

Comment 9

[Julien Cristau [:jcristau] (back August 18)]

Comment on attachment 9206827 [details] [diff] [review]
Beta 87 patch

approved for 87.0b6

Comment 10

[Julien Cristau [:jcristau] (back August 18)]

https://hg.mozilla.org/releases/mozilla-beta/rev/f21ef76a7f8a

Comment 11

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I verified this issue using Fx 88.0a1(2021-03-05) and Fx 87.0b6 on Windows 10 x64, Ubuntu 20.04 and macOS 10.13.