Closed Bug 1696338 Opened 4 years ago Closed 4 years ago

Port bug 1696202: Refactor close-icon.css to use color-mix()

Categories

(Thunderbird :: Upstream Synchronization, task)

Product:
Thunderbird
Component:
Upstream Synchronization
Type:
task

Tracking

(thunderbird_esr78 unaffected, thunderbird87 unaffected)

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
thunderbird_esr78 --- unaffected
thunderbird87 --- unaffected

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

(Whiteboard: land after bug 1696202)

Attachments

(2 files, 2 obsolete files)

1696338-close-icon-port.patch landed in comment 4
1.70 KB, patch
mkmelin
: review+
Details | Diff | Splinter Review
1696338-fup-tweaks.patch
3.26 KB, patch
Paenglab
: review+
Details | Diff | Splinter Review

We need to follow bug 1696202 to let our close icons look correct.

Bug 1696202 is on autoland and could be on M-C on the next merge.

I should have found all close icons that need a fix.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9206844 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9206844 [details] [diff] [review] 1696338-close-icon-port.patch landed in comment 4 Review of attachment 9206844 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, r=mkmelin
Attachment #9206844 - Flags: review?(mkmelin+mozilla) → review+
status-thunderbird87: --- → unaffected
status-thunderbird_esr78: --- → unaffected
Target Milestone: --- → 88 Branch
Keywords: checkin-needed-tb
Whiteboard: land after bug 1696202

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/61bd1f86844c
Port bug 1696202: Refactor close-icon.css to use color-mix(). r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED
Attached patch 1696338-fup-tweaks.patch (obsolete) — — Splinter Review

Bah, found two issues.
Or do you think the big close icons in the tabs are okay?

Attachment #9206929 - Flags: review?(alessandro)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 9206929 [details] [diff] [review] 1696338-fup-tweaks.patch Review of attachment 9206929 [details] [diff] [review]: ----------------------------------------------------------------- Yes, the icon should be smaller in the tab. I'm removing the review due to that tiny regression of the today pane close button we discussed on Matrix.
Attachment #9206929 - Flags: review?(alessandro) → feedback+
Attached patch 1696338-fup-tweaks.patch (obsolete) — — Splinter Review

Gave the today pane closer a margin-end of 3px like the gap was before.

Attachment #9206929 - Attachment is obsolete: true
Attachment #9206978 - Flags: review?(alessandro)
Comment on attachment 9206978 [details] [diff] [review] 1696338-fup-tweaks.patch Review of attachment 9206978 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks.
Attachment #9206978 - Flags: review?(alessandro) → review+
Keywords: checkin-needed-tb
Attachment #9206844 - Attachment description: 1696338-close-icon-port.patch → 1696338-close-icon-port.patch landed in comment 4

The Contacts sidebar close button in Composer had the same issue. Added the same margin as for the today pane closer.

Attachment #9206978 - Attachment is obsolete: true
Attachment #9207012 - Flags: review+

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/0819c9d93014
Additional tweaks after bug 1696202 landing. r=aleca

Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/e6f301ba5910 follow-up - Fix CSS error. rs=bustage-fix
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: