Closed
Bug 1696202
Opened 3 years ago
Closed 3 years ago
Refactor close-icon.css to use color-mix() and update Proton tab close button to match updated spec
Categories
(Toolkit :: Themes, task, P1)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
88 Branch
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: ntim, Assigned: ntim)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-tabs-bar])
Attachments
(1 file)
https://searchfox.org/mozilla-central/source/toolkit/themes/shared/close-icon.css
This gives a few benefits:
- not having to do fill-opacity: 0; to remove the background (which is weird in hindsight), and allows removing all the current overrides.
- aligns close-icon to use fill instead of stroke
- flexibility around the size of background (see bug 1692608)
Let's use background-color: color-mix(in srgb, currentColor 10%, transparent) instead.
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/ad2a774fdc62 Refactor close-icon.css to use color-mix(). r=preferences-reviewers,jaws
|
||
Updated•3 years ago
|
Blocks: proton-tabs-bar
Severity: -- → S3
Priority: -- → P1
Summary: Refactor close-icon.css to use color-mix() → Refactor close-icon.css to use color-mix() and update Proton tab close button to match updated spec
Whiteboard: [proton-tabs-bar]
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox88:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
|
||
Updated•3 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-523
You need to log in
before you can comment on or make changes to this bug.
Description
•