1696789 - Improve address rows selector in pillifyRecipients() to exclude custom headers

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Thomas D. (:thomas8)]

+++ This bug was initially created as a clone of Bug #1688336 +++

While bug 1682147 incidentally fixed bug 1688336 by adding optional chaining operator ?. to an expected autocomplete input, we should adjust the selector for the address rows to only match rows with autocomplete inputs (vs. plain custom headers).

https://searchfox.org/comm-central/rev/460e6636b38cec25bd14bdc542e254ceb0e016a9/mail/components/compose/content/MsgComposeCommands.js#5003-5007

function pillifyRecipients() {
  for (let row of document.querySelectorAll(".address-row:not(.hidden)")) {
    let input = row.querySelector(
      `input[is="autocomplete-input"][recipienttype]`
    );
    // If we find a leftover string in the input field, create a pill. If the
    // newly created pill is not a valid address, the sending will stop.
    if (input?.value.trim()) {
      recipientAddPills(input);
    }
  }
}

Comment 1

[Thomas D. (:thomas8)]

Attachment: 1696789_autocompleteRowInputsSelector.diff

Selector cleanup, now matching only the autocomplete inputs that we want.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7091e06c86a6
Improve selector in pillifyRecipients() to match only autocomplete row inputs. r=aleca