1698461 - Improve selectors and performance of emailAddressPillOnPopupShown()

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, task)

Description

[Thomas D. (:thomas8)]

+++ This bug was initially created as a clone of Bug #1696789 +++

I was looking at emailAddressPillOnPopupShown() while working on bug 1687432.
Let's simplify and cleanup here first. Better selectors are safer and faster, and we should not continue searching when we already know what we need to know.

Comment 1

[Thomas D. (:thomas8)]

Attachment: 1698461_cleanup-emailAddressPillOnPopupShown.diff

Cleanup and improve performance of emailAddressPillOnPopupShown().

• Avoid using querySelectorAll() on unlimited pills where querySelector() suffices.
• Limit queries to #recipientsContainer instead of querying the entire document.
• Bail out early as soon as conditions are satisfied.
• Simplify the code.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9209082 [details] [diff] [review]
1698461_cleanup-emailAddressPillOnPopupShown.diff

Review of attachment 9209082 [details] [diff] [review]:
-----------------------------------------------------------------

This makes sense.
Thanks for the improvements.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/97d9bf011825
Improve selectors and performance of emailAddressPillOnPopupShown(). r=aleca

Comment 4

[Geoff Lankow (:darktrojan)]

I've just noticed this patch got pushed with my username instead of Thomas's. Clearly I screwed up the landing somehow. I'm going to back it out and re-land.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/87031e5a8f0c
Improve selectors and performance of emailAddressPillOnPopupShown(). r=aleca DONTBUILD