Closed
Bug 1696873
Opened 4 years ago
Closed 4 years ago
Enable more ESLint rules on remaining docshell/ xhtml files
Categories
(Core :: DOM: Navigation, task)
Core
DOM: Navigation
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
Following on from bug 1656293, I have a couple of patches to enable more ESLint rules on the remaining docshell xhtml files:
- First is for no-undef.
- Second is to apply automatic fixes enable the dot-notation, object-shorthand and mozilla/no-useless-parameters rules.
The second also enables rules which show no errors.
|
Assignee | |
Comment 1•4 years ago
|
||
Depends on D100450
|
|
Assignee | |
Comment 2•4 years ago
|
||
This automatically fixes issues for these rules: dot-notation, object-shorthand and mozilla/no-useless-parameters
The other enabled rules had no issues associated with them, so are enabled without code changes.
ignore-this-changeset
Depends on D107423
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/15fd373cef34
Enable ESLint rule no-undef on remaining docshell xhtml files. r=smaug
https://hg.mozilla.org/integration/autoland/rev/c90108879ab6
Apply automatic fixes to enable more ESLint rules on remaining docshell xhtml files. r=smaug
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/15fd373cef34
https://hg.mozilla.org/mozilla-central/rev/c90108879ab6
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox88:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•