Closed Bug 1696873 Opened 3 years ago Closed 3 years ago

Enable more ESLint rules on remaining docshell/ xhtml files

Categories

(Core :: DOM: Navigation, task)

task
Points:
2

Tracking

()

RESOLVED FIXED
88 Branch
Iteration:
88.2 - Mar 8 - Mar 21
Tracking Status
firefox88 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Following on from bug 1656293, I have a couple of patches to enable more ESLint rules on the remaining docshell xhtml files:

  • First is for no-undef.
  • Second is to apply automatic fixes enable the dot-notation, object-shorthand and mozilla/no-useless-parameters rules.

The second also enables rules which show no errors.

This automatically fixes issues for these rules: dot-notation, object-shorthand and mozilla/no-useless-parameters
The other enabled rules had no issues associated with them, so are enabled without code changes.

ignore-this-changeset

Depends on D107423

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/15fd373cef34
Enable ESLint rule no-undef on remaining docshell xhtml files. r=smaug
https://hg.mozilla.org/integration/autoland/rev/c90108879ab6
Apply automatic fixes to enable more ESLint rules on remaining docshell xhtml files. r=smaug
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: