Closed
Bug 1697003
Opened 4 years ago
Closed 4 years ago
Update strings for Quicksuggest
Categories
(Firefox :: Address Bar, task, P1)
Firefox
Address Bar
Tracking
()
VERIFIED
FIXED
88 Branch
Tracking | Status | |
---|---|---|
firefox86 | --- | unaffected |
firefox87 | + | verified |
firefox88 | --- | verified |
People
(Reporter: daleharvey, Assigned: daleharvey)
References
Details
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details | Review |
After a product meeting we got some string request changes
- Change "Firefox Suggests" string to "Firefox Suggest" (this is found in a few places)
- Change the search preference string to say "Show Firefox Suggest in the address bar (suggested and sponsored results)"
Assignee | ||
Comment 1•4 years ago
|
||
Comment 2•4 years ago
|
||
[Tracking Requested - why for this release]:
This is a last-minute request from management that we need for the contextual services/quick suggest experiment on 87.
Points: --- → 1
status-firefox86:
--- → unaffected
status-firefox87:
--- → affected
status-firefox88:
--- → affected
tracking-firefox87:
--- → ?
Updated•4 years ago
|
Pushed by dharvey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ba251d9b1d34
Update strings for Firefox Suggest experiment r=adw
Comment 4•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Assignee | ||
Comment 5•4 years ago
|
||
Comment on attachment 9207560 [details]
Bug 1697003 - Update strings for Firefox Suggest experiment
Beta/Release Uplift Approval Request
- User impact if declined: We need this for the contextual services/quick suggest experiment in 87.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Its a change to hardcoded (single locale) strings only
- String changes made/needed:
Attachment #9207560 -
Flags: approval-mozilla-beta?
Comment 6•4 years ago
|
||
Comment on attachment 9207560 [details]
Bug 1697003 - Update strings for Firefox Suggest experiment
approved for 87.0b9
Attachment #9207560 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 7•4 years ago
|
||
bugherder uplift |
Comment 8•4 years ago
|
||
This has been verified as part of the quicksuggest sign off process.
Confirming the issue is verified fixed in Fx89.0a1 and Fx88.0b9 on Windows 10 and Ubuntu 18.04. Strings are correctly displayed.
You need to log in
before you can comment on or make changes to this bug.
Description
•