1697751 - Visual glitches occur when the notification window appears

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[nayinain]

Attachment: testcase.html

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:88.0) Gecko/20100101 Firefox/88.0

Steps to reproduce:

1. Open the testcase.html.
2. Click the Show a Notification button.

Actual results:

Visual glitches appear on the notification window.

Expected results:

Without any visual glitch.

Comment 1

[nayinain]

Attachment: Capture.webm

Regression window:

2021-03-11T17:01:12.050000: INFO : platform_buildid: 20210310140852
2021-03-11T17:01:12.050000: INFO : platform_changeset: 97565326ca40d150f65bae3acf92178851180ca1
2021-03-11T17:01:12.050000: INFO : platform_repository: https://hg.mozilla.org/integration/autoland
2021-03-11T17:01:12.051000: INFO : platform_version: 88.0a1
2021-03-11T17:01:29.734000: INFO : Narrowed integration regression window from [5dbc5dd9, 0c5f0b28] (3 builds) to [97565326, 0c5f0b28] (2 builds) (~1 steps left)
2021-03-11T17:01:29.740000: DEBUG : Starting merge handling...
2021-03-11T17:01:29.740000: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=0c5f0b28261bfe990f6e3bc71fd57d1a32e69082&full=1
2021-03-11T17:01:29.740000: DEBUG : redo: attempt 1/3
2021-03-11T17:01:29.740000: DEBUG : redo: retry: calling _default_get with args: ('https://hg.mozilla.org/integration/autoland/json-pushes?changeset=0c5f0b28261bfe990f6e3bc71fd57d1a32e69082&full=1',), kwargs: {}, attempt #1
2021-03-11T17:01:29.746000: DEBUG : urllib3.connectionpool: Resetting dropped connection: hg.mozilla.org
2021-03-11T17:01:31.213000: DEBUG : urllib3.connectionpool: https://hg.mozilla.org:443 "GET /integration/autoland/json-pushes?changeset=0c5f0b28261bfe990f6e3bc71fd57d1a32e69082&full=1 HTTP/1.1" 200 None
2021-03-11T17:01:31.268000: DEBUG : Found commit message:
Bug 1697040 - Turn on Software WebRender for Windows popups with transparency in nightly and early beta. r=jrmuizel

Differential Revision: https://phabricator.services.mozilla.com/D107759

2021-03-11T17:01:31.269000: DEBUG : Did not find a branch, checking all integration branches
2021-03-11T17:01:31.270000: INFO : The bisection is done.
2021-03-11T17:01:31.271000: INFO : Stopped

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

[Tracking Requested - why for this release]:

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: about:support information

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Happens on Windows 10 too.

Comment 5

[Andrew Osmond [:aosmond] (he/him)]

Seems to be this animation that is having trouble:

https://searchfox.org/mozilla-central/rev/87a8afd9f57ee4bc542ba0ec3f96a891042b6db7/toolkit/themes/shared/alert.inc.css#9

If I manage to hover before the animation completes, it immediately draws okay, presumably because the opacity is set to opaque:

https://searchfox.org/mozilla-central/rev/87a8afd9f57ee4bc542ba0ec3f96a891042b6db7/toolkit/themes/shared/alert.inc.css#25

Comment 6

[Ted Campbell [:tcampbell]]

Hitting this on Win10 with hw webrender (Intel(R) UHD Graphics 620) too.

Comment 7

[Andrew Osmond [:aosmond] (he/him)]

If I force it to use HW-WR with the popups instead of SW-WR, I don't see the problem.

Comment 8

[Lee Salzman [:lsalzman]]

Did bug 1698067 help this at all?

Comment 9

[Andrew Osmond [:aosmond] (he/him)]

(In reply to Lee Salzman [:lsalzman] from comment #8)

Did bug 1698067 help this at all?

No, it still reproduces the same for me.

Comment 10

[Andrew Osmond [:aosmond] (he/him)]

This won't ship in 88 in release -- it is turned on in early beta and earlier, and during the fission experiment.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Bug 1700153 should resolve this for Beta88.

Comment 15

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1697751 - Clamp brush_opacity opacity values into the 0..1 range. r?lsalzman

Comment 16

[Matt Woodrow (:mattwoodrow)]

It looks like the animation computes opacity values > 1.0, which then confuses the SWGL fast paths and generates invalid pixel data.

Hiro, should we be clamping opacity values during animations somewhere?

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1d76464ed82
Clamp brush_opacity opacity values into the 0..1 range. r=lsalzman

Comment 18

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c1d76464ed82

Comment 19

[Hiroyuki Ikezoe (:hiro)]

(In reply to Matt Woodrow (:mattwoodrow) from comment #16)

It looks like the animation computes opacity values > 1.0, which then confuses the SWGL fast paths and generates invalid pixel data.

Hiro, should we be clamping opacity values during animations somewhere?

Right, I hadn't been aware of the issue for long time. Filed bug 1704395.

Comment 20

[Jim Mathies [:jimm]]

Tested notifications and the proton hamburger menu issue, both appear to be fixed.