1700153 - Don't automatically enable SW-WR popups with the Fission experiment or on early beta

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P2)

Description

[Andrew Osmond [:aosmond] (he/him)]

It is causing more problems than we would see with Fission + basic layers popups. Let's keep it in nightly only for now.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1700153 - Disable SW-WR for transparent popups on early beta and the Fission experiment.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c880ca8e4dd1
Disable SW-WR for transparent popups on early beta and the Fission experiment. r=jrmuizel

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c880ca8e4dd1

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 9210801 [details]
Bug 1700153 - Disable SW-WR for transparent popups on early beta and the Fission experiment.

Beta/Release Uplift Approval Request

• User impact if declined: We are seeing issues with Software WebRender popups in nightly. It is probably better to not ship that to beta for the time being. The bug we were trying to fix which Fission has is more tolerable/rare than these issues.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Not tested in nightly because we are keeping it on there but it is largely just a pref flip, and not forcing it on if in the Fission experiment. We are shipping this configuration today in release and we know it is working better.
• String changes made/needed:

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9210801 [details]
Bug 1700153 - Disable SW-WR for transparent popups on early beta and the Fission experiment.

Approved for 88.0b2.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3b2ef2567fcb

Comment 7

[Alexandru Ionescu (needinfo me) [:alexandrui]]

:aosmond, makes sense that the below regression was caused by this bug? It's a noisy alert that points to this bug slightly.
== Change summary for alert #29408 (as of Tue, 23 Mar 2021 21:53:54 GMT) ==

Regressions:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
12%	tresize		windows10-64-shippable	e10s stylo	8.57 -> 9.62

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=29408

Comment 8

[Andrew Osmond [:aosmond] (he/him)]

No, this should only affect WebRender performance at best (this is a non-WebRender test), and popups are unlikely to appear on hot paths anyways.