1698377 - Profiler button dropdown still appears after the button overflows

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P2)

Description

[Itiel]

Attachment: Screenshot

See attached (I made both items with the hover effect just so the styling for both would be clear)

Comment 1

[:Gijs (he/him)]

Mark, can you prio this for toolbar / hamburger menu work? Is this perhaps already covered under bug 1698436 ?

Comment 2

[Harry Twyford]

This is being handled in bug 1698436.

Comment 3

[alex_mayorga]

Attachment: image.png

¡Hola y'all!

Gijs mentioned at https://matrix.to/#/!rHHMKzcUcGkdujJeis:mozilla.org/$5bNkPVNyD2UhLNZDS3JeXRKyQOW61MPbDixs2yhtNhQ?via=mozilla.org&via=matrix.org&via=fairydust.space to reopen this one.

¡Gracias!
Alex

Comment 4

[Molly Howell (she/her) (no longer active)]

To be clear, the bug in comment 3 is that the dropdown appeared at all; it's only supposed to be there when the button is in the toolbar, not in the overflow list.

@alex_mayorga, do you have a reliable way to reproduce this? I've been trying and I can't seem to make it happen at all, nor can I see a way that it looks like it could (not one that's obvious enough for me to find it, anyway).

Comment 5

[alex_mayorga]

¡Hola Molly!

All that I need to do is to reduce the window to half the screen either left or right so the profiler hides under the overflow menu >> , then click the overflow menu >> and the bug manifest itself.

Hope this helps.

¡Gracias!
Alex

Comment 6

[alex_mayorga]

Attachment: image.png

Comment 7

[alex_mayorga]

Attachment: image.png

Comment 8

[Molly Howell (she/her) (no longer active)]

Ooooooh, it's when the button is in the toolbar but it overflows into that menu, okay, thank you, that's exactly what I needed to know, I think I know how to fix this now.

Comment 9

[Molly Howell (she/her) (no longer active)]

Attachment: Bug 1698377 - Treat button-and-view widgets as being in a panel when they overflow off the toolbar. r=mstange

When a toolbar button overflows out of the toolbar and into the overflow menu,
CustomizableUI continues to report the widget's type as "toolbar". This means
that whether the widget is currently overflowed must be considered in addition
to the widget's type when the panel and toolbar states need different handling.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7032f1775c4b
Treat button-and-view widgets as being in a panel when they overflow off the toolbar. r=Gijs

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7032f1775c4b

Comment 12

[Catalin Sasca, Desktop QA [:csasca]]

Attachment: profiler overflow cut win 10.jpg

Reproduced the issue on Firefox (2021-03-14) under macOS 10.15.7. The issue seems to be fixed on Firefox 89.0b9 and 90.0a1 under macOS 10.15.7 and Ubuntu 20.04.

Windows 10 on the other hand still seems to have the profiler in overflow cut (see attachment). Anything we can do?

Comment 13

[Molly Howell (she/her) (no longer active)]

Oh, sorry, this bug wasn't for the panel itself overflowing, this was about the button that opens the panel. That should be a separate bug.

Comment 14

[Catalin Sasca, Desktop QA [:csasca]]

Understood, then the issue for the button that opens the panel is fixed as verified, as mentioned in Comment 12.