1650835 - Support toolbar buttons that have a default action, and a drop marker to open a panel with more options

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, enhancement, P5)

Description

[Florian Quèze [:florian]]

I hacked this in bug 1621015 for the profiler toolbar icon, so that the profiler icon itself starts/stops the profiler, and a dropmarker opens a panel to configure the profiler.

It would be nice to support this more generically so that other buttons could use it. The devtools button would most likely also want to use this, when the click on the icon would open/close devtools, and the dropmarker would open the current menu which lists various developer tools.

Probably low priority as we have something that currently works well enough for the profiler button.

Comment 1

[Markus Stange [:mstange]]

I'm taking a stab at this because bug 1650833 is bothering me personally.

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1650835 - Add support for a "button-and-view" widget type. r=jaws

This widget will be used for the profiler button. The profiler button is a
two-part widget with both a command and a view. The command starts/stops the
profiler, but the starting/stopping can also be performed from inside the view.
The dropmarker button shows the view.
When this widget is located in the panel, the start/stop action is only
accessible via the view and there is no "quick-action" command.

The structure of the widget is as follows:

toolbaritem.toolbaritem-combined-buttons

• toolbarbutton.toolbarbutton-1
• toolbarbutton.toolbarbutton-1.toolbarbutton-combined-buttons-dropmarker

The dropmarker icon is the toolbarbutton icon of the second toolbarbutton.
The dropmarker button is only shown in the toolbar or in the customize palette.
It is hidden when the widget is located in the panel.
In the toolbar, the hover effect of the dropmarker needs to have the same height
as the hover effect of the regular button. However, due to the different image
size (12x12 instead of 16x16) it requires more vertical padding.

Depends on D98214

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1650835 - Use a "button-and-view" widget for the profiler button. r=florian

Depends on D98216

Comment 4

[Markus Stange [:mstange]]

https://treeherder.mozilla.org/jobs?repo=try&revision=871d04db54b06c976e61cbf7f059db3e3d69cd38
https://treeherder.mozilla.org/jobs?repo=try&revision=0de5c7460aee7b349dc3f5988b9146aa5dc74ffc

Comment 5

[Markus Stange [:mstange]]

https://treeherder.mozilla.org/jobs?repo=try&revision=839053dcf34553e96db433278f4366845e2d45df

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1580fce94a2d
Add support for a "button-and-view" widget type. r=jaws
https://hg.mozilla.org/integration/autoland/rev/9d54a5418434
Use a "button-and-view" widget for the profiler button. r=florian

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/1580fce94a2d
https://hg.mozilla.org/mozilla-central/rev/9d54a5418434