Open Bug 1698693 Opened 2 months ago Updated 14 days ago

Audit APZ-related callers of GetCrossDocParentFrame()

Categories

(Core :: Panning and Zooming, task)

task

Tracking

()

Fission Milestone M7a

People

(Reporter: botond, Assigned: botond, NeedInfo)

References

(Blocks 2 open bugs)

Details

In this bug, I'm going to audit the APZ-related callers of GetCrossDocParentFrame(), and migrate them to GetCrossDocParentFrameInProcess() as appropriate.

This is... quite the rabbit hole. For instance, should SetZeroMarginDisplayPortOnAsyncScrollableAncestors() set displayports on cross-process ancestors? (If so, we'd need new IPC protocols to support that.)

(In reply to Botond Ballo [:botond] from comment #1)

For instance, should SetZeroMarginDisplayPortOnAsyncScrollableAncestors() set displayports on cross-process ancestors?

Is this function even needed anymore (in Fission mode), now that every async-scrollable frame gets a minimal displayport (since bug 1675547)?

Yeah, this can really rabbit hole.

(In reply to Botond Ballo [:botond] from comment #2)

(In reply to Botond Ballo [:botond] from comment #1)

For instance, should SetZeroMarginDisplayPortOnAsyncScrollableAncestors() set displayports on cross-process ancestors?

Is this function even needed anymore (in Fission mode), now that every async-scrollable frame gets a minimal displayport (since bug 1675547)?

Not really needed in fission mode no, the minimal displayports should make sure that we don't have to activate a scrollframe after descending into it.

I purposely didn't touch SetZeroMarginDisplayPortOnAsyncScrollableAncestors when adding minimal displayports to keep the scope reasonable. I think there are still a few open questions about the minimal display port approach so I want them to bake a bit more before we refactor in this area. It seems like all the regressions we've found in apz lately get reported 3-4 months after landing, and fission is still getting rolled out to a wider audience, so I'm not ready to stamp the minimal displayport approach with the "working well" stamp yet.

Component: Layout → Panning and Zooming

Let's track this for M7a, like the bug it blocks.

Fission Milestone: --- → M7a
Blocks: apz-fission

Botond, gentle reminder about this M7a audit bug assigned to you.

Flags: needinfo?(botond)
You need to log in before you can comment on or make changes to this bug.