1699814 - Perma Windows bugs/1174332-1.html == bugs/1174332-1-ref.html | image comparison, max difference: 255, number of differing pixels: 96 when Gecko 88 merges to Beta on 2021-03-22

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: archaeopteryx [at] coole-files.de
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=333792307&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/IPN_PvKYRKyYu2n3ZoPPSQ/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/IPN_PvKYRKyYu2n3ZoPPSQ/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

Hit this for reftest, reftest-gpu and reftest-no-accel on Windows 7 shippable for today's autoland-as-beta simulation.```

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Actually, it's permanent on Windows.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

So I think the patch for bug 1174332 was a bit broken, in the sense that it shouldn't apply to widgets that have overflow because of outlines. The test-case there looks pretty broken with the non-native theme when the checkboxes have focus outlines.

For now I guess we could annotate the failure to keep the test happy but I don't think bug 1174332 was quite correct.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1699814 - Annotate a failure that already happens in a lot of other themes pending more discussion in bug 1699924.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00bab85fab62
Annotate a failure that already happens in a lot of other themes pending more discussion in bug 1699924.

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/611cbc8e6ee6
Backed out changeset 00bab85fab62 for osx reftest failures.

Comment 6

[Cosmin Sabou [:CosminS]]

This will be relanded as the failures were from Bug 1699931.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d7241c8e75a
Annotate a failure that already happens in a lot of other themes pending more discussion in bug 1699924.

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2d7241c8e75a

Comment 9

[Andreea Pavel [:apavel]]

Verified fixed in latest beta-sim: https://treeherder.mozilla.org/jobs?repo=try&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=208e86facf3bfc82684d27cce23e036699192c4b&searchStr=reftest&group_state=expanded

Comment 10

[Intermittent Failures Robot]

1 failures in 4257 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform and build breakdown:

• windows10-64-shippable: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1699814&startday=2021-03-15&endday=2021-03-21&tree=all