1700101 - The Library panel is broken when accessing the History option

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Ciprian Georgiu, Desktop QA]

Attachment: LibraryMenu.gif

Affected versions

• latest Nightly 88.0a1

Preconditions

• Have around 30 sites populated in History.
• Library icon (from Customize page) is dragged & dropped into toolbar.

Affected platforms

• Windows 10 x64

Steps to reproduce

1. Click on the Library icon from the toolbar.
2. Click on the History option.
3. Rapidly close the panel via "<" button from the sub panel.
4. Repeat steps 2 and 3, if the issue is not reproduced instantly.

Expected result

• The Library panel is correctly displayed.

Actual result

• The Library panel is broken.

Suggested Severity

• S2, since this is a regression.

Regression range

• changeset: 97565326ca40d150f65bae3acf92178851180ca1
• pushlog_url: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=97565326ca40d150f65bae3acf92178851180ca1&tochange=0c5f0b28261bfe990f6e3bc71fd57d1a32e69082

• Potential regressor: Bug 1697040

Additional notes

• it seems that this issue is Windows specific. I cannot reproduce it on Ubuntu nor macOS.
• please see the attached screencast.
• I can also reproduce this with browser.proton.enabled set to false.

Comment 1

[:Gijs (he/him)]

This was filed today, and though very similar to bug 1698846 the conversation at https://bugzilla.mozilla.org/show_bug.cgi?id=1698846#c7 is from 3 days ago, so I assume this is not yet fixed... Jamie, can you take a look or forward to the right person?

Comment 2

[Jamie Nicol [:jnicol]]

Here's another one Andrew :)

Comment 3

[Alice0775 White]

I can reproduce this with/without proton on Windows10. And this is more reproducible than bug 1698846.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Bug 1700153 will resolve this issue for Beta88.

Comment 5

[Vicky Chin [:vchin]]

I tried on a new profile without the proton flags using the latest Nightly and am not able to reproduce while I can reproduce fairly easily with the proton flags on. Windows 10.

Comment 10

[Alice0775 White]

I have found a way to reproduce this bug 100% on Nightly89.0a1 Windows10 with/without Proton.

STR:

1. Put Text Encoding toolbutton in Overflow Menu.
2. Open data:text/html;Shift_JIS,Other than UTF-8:%E3%81%82<a href="https://www.google.com" style="float:right;padding-right:50px;">Go to Google</a>
3. Click Overflow Menu button.
4. Click Text Encoding to open sub-view.
5. Click < button at the top-left corner of the menu

Optionally
6. Once after this bug happen, attempt to click Go to Google link.

Actual Results:
This bug appears[step.5].
Once after this bug have happened, The Overflow Menu is always broken.
And the link is not responding[step.6]

Comment 12

[Mike Conley (:mconley) (:⚙️)]

I can reproduce this fairly easily. Investigating.

Comment 13

[Mike Conley (:mconley) (:⚙️)]

Okay, I can't seem to reproduce this with gfx.webrender.software.unaccelerated-widget.allow set to false (which is effectively a backout of bug 1697040).

Alice0775, do you see the same behaviour? If you set gfx.webrender.software.unaccelerated-widget.allow to false and restart, can you still reproduce the bug?

Comment 14

[Mike Conley (:mconley) (:⚙️)]

Presuming this is caused by gfx.webrender.software.unaccelerated-widget.allow, this might result in a change of priority.

Tyler, I spoke to jimm about this. It seems as if this is caused by gfx.webrender.software.unaccelerated-widget.allow, which is a pref that allows the WebRender software fallback to be used for panels. This preference is enabled on EARLY_BETA_OR_EARLIER and Nightly, primarily to solve problems with Fission experiments that are running on 88 Beta and 89 Nightly.

I think the main takeaway though is that gfx.webrender.software.unaccelerated-widget.allow is not set to ride out to release in either 88 or 89. So presuming this pref is the sole cause of the glitch, then release channel users will never see it.

Given the above, and that we think only Nightly and Beta users will see this glitch, and that the Library panel itself has been de-emphasized with Proton, do we still believe this to be a P1 blocker?

Edit: it looks like gfx.webrender.software.unaccelerated-widget.allow is Nightly only for now, as of bug 1700153.

Comment 15

[Alice0775 White]

(In reply to Mike Conley (:mconley) (:⚙️) (Catching up on needinfos) from comment #13)

Alice0775, do you see the same behaviour? If you set gfx.webrender.software.unaccelerated-widget.allow to false and restart, can you still reproduce the bug?

Yes, setting gfx.webrender.software.unaccelerated-widget.allow to false will fix this issue.

[Edit]
No. I can still reproduce this issue even if set the pref to false, but it is rare....

Comment 16

[Mike Conley (:mconley) (:⚙️)]

No. I can still reproduce this issue even if set the pref to false, but it is rare....

Thanks, Alice0775 - did you need to change any of your steps in order to reproduce it with the pref disabled?

Comment 17

[Alice0775 White]

(In reply to Mike Conley (:mconley) (:⚙️) (Catching up on needinfos) from comment #16)

No. I can still reproduce this issue even if set the pref to false, but it is rare....

Thanks, Alice0775 - did you need to change any of your steps in order to reproduce it with the pref disabled?

I think nothing special steps.
Screencast: https://youtu.be/V-8EIxgG6s8?t=26

Comment 18

[Mike Conley (:mconley) (:⚙️)]

Thanks, Alice0775. Can you please attach your current about:support?

Comment 19

[Alice0775 White]

Attachment: about:support

(In reply to Mike Conley (:mconley) (:⚙️) (Catching up on needinfos) from comment #18)

Thanks, Alice0775. Can you please attach your current about:support?

Comment 20

[Mike Conley (:mconley) (:⚙️)]

Alright, I'm having no luck reproducing this, but Alice0775 can (but it's rare).

I'm going to modify what I wrote in comment 14:

We think that gfx.webrender.software.unaccelerated-widget.allow makes this problem much easier to hit, but we're able to get a similar broken state even with the pref disabled.

tduzan, I'm still unsure if this should qualify as a P1 given that:

1. gfx.webrender.software.unaccelerated-widget.allow set to true, which makes the problem much easier to hit, is held to Nightly right now
2. When gfx.webrender.software.unaccelerated-widget.allow is false it's possible to hit a similar issue, but it's much much more rare.

What do you think?

Comment 21

[Jim Mathies [:jimm]]

My situation is similar to Mike's, with swiggle for popups this reproduces after a few expansions of the drop down. Without swiggle I can't reproduce.

Graphics team is looking at this.

Comment 22

[Romain Testard [:RT]]

FWIW I could reproduce consistently and setting gfx.webrender.software.unaccelerated-widget.allow to false fixes the issue.
Is that an option to disable gfx.webrender.software.unaccelerated-widget.allow on nightly as we enable the proton pref? (concern here is getting Proton useage on a feature that has fair amount of use)

Comment 23

[Jim Mathies [:jimm]]

We're going to turn the popup pref off in Nightly today. Any remaining issue may be something entirely different, so a regression range on that would be helpful.

Comment 24

[Alice0775 White]

I have filed Bug 1703569 under gfx.webrender.software.unaccelerated-widget.allow=false.

Comment 25

[Mike Conley (:mconley) (:⚙️)]

The backout for bug 1703524 has landed, and the bug is now closed. This bug should be hard (but not impossible - see bug 1703569) to hit in the next Nightly build.

I'm going to close this out as RESOLVED FIXED. Prioritization and investigation for the rarer case should be done in bug 1703569.

Comment 26

[Alexandru Trif, Desktop Test Engineering [:atrif]]

I can confirm I can no longer reproduce the issue with Firefox 89.0a1 (20210407212527) on Windows 10x64 by following comment 0 and comment 10 steps. Tried multiple times with proton enabled and disabled and the issue is no longer occurring. Also, a quick check was performed on macOS M1 11.2.3 and Ubuntu 20. Closing this as verified.