1700194 - Bookmark Button on Toolbar - Proton Bookmark popup double Borders

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Serge]

Attachment: boomarks.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:88.0) Gecko/20100101 Firefox/88.0

Steps to reproduce:

EnableProtonUI
browser.proton.contextmenus.enabled
browser.proton.enabled
browser.proton.tabs.enabled
browser.proton.toolbar.enabled
browser.proton.urlbar.enabled

Place "Show Your Bookmarks" button to Navbar
Click on In
Observe PopUp position

Actual results:

Bookmark PopUp suffers from effect of "Double" borders/Shadows. Also the background color is slightly different

Expected results:

Bookmark PopUp should be have correct visual design

Comment 1

[Andrei Purice]

Reproduced on 89.0a1 (2021-03-23) and beta 88.0b1 using the prefs given.
Setting up flags for visibility and marking it as New.
Hey Romain, can you advise us what Severity should this issue have?

Comment 2

[Romain Testard [:RT]]

Mike can you please confirm if resolving this is already part of bug 1697507?

Comment 3

[Mike Conley (:mconley) (:⚙️)]

This seems like it might be a dupe of bug 1692080. Serge, can you check to see if this is fixed in a recent Nightly?

Comment 4

[Serge]

Hi Mike,
I have updated Nightly to the latest version and the issue is still here

Comment 5

[Serge]

Attachment: bookmark2.png

Comment 6

[Mike Conley (:mconley) (:⚙️)]

What if you set browser.proton.doorhangers.enabled to true?

Comment 7

[Serge]

browser.proton.doorhangers.enabled>true
The issue is still here

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Okay, thanks Serge.

In that case, bug 1697507 did not address this, and this is an open issue with Proton enabled. How do you want to prioritize it, rtestard?

Comment 9

[Romain Testard [:RT]]

Setting as P1 given that the panel restyle was part of the experience review priorities, we should discuss this one in particular as part of today's triage session (hard to assess if this gets high visibility given we have no telemetry for this).

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Attachment: image.png

Hey Serge, I'm having trouble reproducing this... the screenshot I just attached is what I'm seeing. Can you show me what you're seeing with the browser.proton.doorhangers.enabled pref set to true?

Comment 11

[Serge]

Hi Mike,
The issue is related to browser.proton.contextmenus.enabled
If I set it to True, the issue is visible
Here is a comparison

Comment 12

[Serge]

Attachment: bookmark3.png

Comment 13

[Mike Conley (:mconley) (:⚙️)]

Ah, I'm able to reproduce on Windows 10, but not Windows 7. Thank you!

Comment 14

[Mike Conley (:mconley) (:⚙️)]

Also yes, Serge is right in comment 11: browser.proton.contextmenus.enabled must be set to true. Thanks for your help, Serge!

Comment 15

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1700194 - Suppress extra borders around Bookmarks Tray button menus when Proton is enabled on Windows 10. r?Itiel

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c2cc9846ad6
Suppress extra borders around Bookmarks Tray button menus when Proton is enabled on Windows 10. r=Itiel,desktop-theme-reviewers

Comment 17

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/5c2cc9846ad6

Comment 18

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Attachment: corners.jpg

Reproduced the issue on Firefox (2021-03-22) under Windows 10 only by following the informations provided in Comment 0.

The initial issue for the borders/shadows is fixed in Firefox 89.0b10 and Firefox 90.0a1.

Seems that now the corners for the submenus are not rounded (see attachment). Is this known or should a new bug be filed for it?

Comment 19

[Mike Conley (:mconley) (:⚙️)]

Thanks csasca - I suggest a new bug for that.

Comment 20

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Thanks Mike, logged Bug 1710556 as a follow up.