1700240 - libotr in official builds should be consistently named

Status: RESOLVED FIXED

(Thunderbird :: Build Config, task)

Description

[Rob Lemley [:rjl]]

To make it clear which arch it's for when looking at the builds.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1700240 - Rename toolchain-macosx64-libotr to toolchain-macosx64-x64-libotr. r=justdave

Makes it obvious what architecture it's for and is more consistent with the
macosx64 build jobs.

Comment 2

[Rob Lemley [:rjl]]

Adding to this bug:

• statically link to libgcrypt and libgpg-error on Windows
• final shared library should not have a versioned filename like the rest of the shared libraries in the application directory (eg. libotr.so, otr.dll, libotr.dylib)

Comment 3

[Rob Lemley [:rjl]]

Attachment: Bug 1700240 - Compile libotr with generic SONAME and statically linked to deps on Windows. r=justdave

It's quite cumbersome to have the filename be versioned (eg. libotr.so.5) as
the way it's done is inconsistent between the supported platforms. Libtool
insists on using the full names, so bypass it with a link command that
sets the SONAME correctly as well.

Additionally, statically link the dependencies for Windows builds like the
other platforms.

Comment 4

[Rob Lemley [:rjl]]

Attachment: Bug 1700240 - Update packaging for correct name of libotr shared library. r=justdave

Windows is of course the outlier, there is no "lib" prefix usually on shared
libraries, but that is how OTRLib.jsm wants the file to be named so it's
artificially added where needed.

Depends on D109488

Comment 5

[Rob Lemley [:rjl]]

Attachment: Bug 1700240 - Look for unversioned libotr library in Thunderbird application directory. r=kaie

Depends on D109489

Comment 6

[Kai Engert (:KaiE:)]

I think this should be trunk only, not 78.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5d48762394c1
Rename toolchain-macosx64-libotr to toolchain-macosx64-x64-libotr. r=justdave
https://hg.mozilla.org/comm-central/rev/46164b8b5b3c
Compile libotr with generic SONAME and statically linked to deps on Windows. r=justdave
https://hg.mozilla.org/comm-central/rev/2336d63760bf
Update packaging for correct name of libotr shared library. r=justdave
https://hg.mozilla.org/comm-central/rev/f332f703490e
Look for unversioned libotr library in Thunderbird application directory. r=kaie