1724914 - [win32] libotr.dll links to (missing) libgcc_s_sjlj-1.dll

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect, P2)

Description

[Rob Lemley [:rjl]]

Likely a regression from bug 1700240.

An additional DLL (libgcc_s_sjlj-1.dll ) started getting linked in the libotr build, but only win32.

The functions that are used from libgcc_s_sjlj-1.dll are __udivdi3 and __umoddi3. These are functions from libgcc to do 64-bit math on 32-bit architectures. There's several possible fixes, but the easiest appears to be ensuring that libgcc is statically linked with -static-libgcc.

There's an xpcshell test that is supposed to detect this kind of failure, yet it passes in Treeherder on win32.

Win64:

➜ mingw-ldd libotr.dll
        msvcrt.dll => /usr/lib/wine/x86_64-windows/msvcrt.dll
        advapi32.dll => /usr/lib/wine/x86_64-windows/advapi32.dll
        ws2_32.dll => /usr/lib/wine/x86_64-windows/ws2_32.dll
        libssp-0.dll => libssp-0.dll

Win32:

➜ mingw-ldd libotr.dll
        msvcrt.dll => /usr/lib32/wine/i386-windows/msvcrt.dll
        advapi32.dll => /usr/lib32/wine/i386-windows/advapi32.dll
        ws2_32.dll => /usr/lib32/wine/i386-windows/ws2_32.dll
        libgcc_s_sjlj-1.dll => **not found**
        libssp-0.dll => libssp-0.dll
`

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1724914 - Build libotr for win32 with -static-libgcc. r=clokep

Win32 builds need to pick up two functions from libgcc (__udivdi3, __umoddi3).
Statically link it so that we do not need to ship an additional DLL.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a3337d3e850e
Build libotr for win32 with -static-libgcc. r=clokep

Comment 3

[Magnus Melin [:mkmelin]]

Is this causing the linux bustages?

Comment 4

[Geoff Lankow (:darktrojan)]

I dunno, it shouldn't affect Linux but it still looks suspicious. I started a Linux build on the Try run to see what happens.

Comment 5

[Geoff Lankow (:darktrojan)]

It builds on Try, so no, I don't think this is causing the bustage.

Comment 6

[Rob Lemley [:rjl]]

Comment on attachment 9235596 [details]
Bug 1724914 - Build libotr for win32 with -static-libgcc. r=clokep

[Approval Request Comment]
Regression caused by (bug #): 1700240
User impact if declined: OTR chat encryption does not work on Windows x86 builds
Testing completed (on c-c, etc.): I verified it works now off nightly
Risk to taking this patch (and alternatives if risky): Low risk, just added a flag to the linker command to pick up the missing functions.

Comment 7

[Rob Lemley [:rjl]]

Comment on attachment 9235596 [details]
Bug 1724914 - Build libotr for win32 with -static-libgcc. r=clokep

[Triage Comment]
Approved for 92.0b1

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 92.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/3967d8a3b17a

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9235596 [details]
Bug 1724914 - Build libotr for win32 with -static-libgcc. r=clokep

[Triage Comment]
Approved for esr91 per chat discussion

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 91.0.1:
https://hg.mozilla.org/releases/comm-esr91/rev/78579765a2af