1701230 - Focus the dialog element instead of the first focusable item as the default behaviour

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, task, P2)

Description

[Sean Feng [:sefeng][PTO, back July 1st]]

We believe having the default focus to be the dialog itself is an improvement to accessibility to provide consistent behaviours for our users.

There's a already a spec PR for it https://github.com/whatwg/html/pull/2197/files https://github.com/whatwg/html/pull/4184. Let's see if we can make it happen.

Comment 1

[Darryl Pogue]

There is also https://github.com/whatwg/html/pull/4184 which would make this the default behaviour without changing the showModal API.

Comment 2

[Sean Feng [:sefeng][PTO, back July 1st]]

Oh yeah, Thanks! I linked to the wrong PR in the description. Let's try to make https://github.com/whatwg/html/pull/4184 happens, then we don't need https://github.com/whatwg/html/pull/2197/.

Comment 3

[Sean Feng [:sefeng][PTO, back July 1st]]

Attachment: Bug 1701230 - Focus the dialog element instead of the first focusable item as the default behavior r=smaug

Instead of focusing the first focusable element, which may be any
element, having the focus to be the dialog itself is an improvement to
accessibility to provide consistent behavior for our uses.

See https://github.com/whatwg/html/pull/4184 for details.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:sefeng, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

(I don't think this needs my attention)

Comment 6

[Sean Feng [:sefeng][PTO, back July 1st]]

I don't think I need to keep this needinfo..just need to resolve https://github.com/whatwg/html/pull/4184

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

:sefeng this is currently blocking https://mozilla-hub.atlassian.net/browse/FXP-839 from being closed, is there anything more to do? Should we remove it as a subtask?

Comment 8

[Sean Feng [:sefeng][PTO, back July 1st]]

Ah okay, so we need to get bug 1811129 implemented (I'll do that), then this one should be resolved.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Should be closed now probably?

Comment 10

[Sean Feng [:sefeng][PTO, back July 1st]]

Yeah!