1811129 - Implement new dialog initial focus algorithm

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, enhancement)

Description

[Joey Arhar]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/110.0.0.0 Safari/537.36

Expected results:

We are speccing a new initial focus steps for the dialog element here: https://github.com/whatwg/html/pull/8199
Tests are here: https://github.com/web-platform-tests/wpt/pull/36831

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: UI Events & Focus Handling' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Sean Feng [:sefeng][PTO, back July 1st]]

Attachment: Bug 1811129 - Implement the new dialog initial focus algorithm r=#dom-core,emilio

The main changes of the new algorithm are

• Make the dialog focusing steps look at sequentially focusable elements instead of any focusable element.
• Make the dialog element itself get focus if it has the autofocus attribute set.
• Make the dialog element itself get focus as a fallback instead of focus being "reset" to the body element.

Spec PR (merged): https://github.com/whatwg/html/pull/8199

Comment 3

[Thomas Wisniewski [:twisniewski]]

I'm guessing this will let Firefox pass these three interop2022 WPTs?

• https://wpt.fyi/results/html/semantics/interactive-elements/the-dialog-element/show-modal-focusing-steps.html
• https://wpt.fyi/results/html/semantics/interactive-elements/the-dialog-element/dialog-showModal.html
• https://wpt.fyi/results/html/semantics/interactive-elements/the-dialog-element/dialog-focus-shadow.html

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cbf5ea1b17d2
Implement the new dialog initial focus algorithm r=emilio

Comment 5

[Norisz Fay [:noriszfay]]

Backed out for causing failures on modal-dialog-backdrop-opacity.html, content-visibility-with-top-layer-006.html, browser_quicksuggest_onboardingDialog.js

Backout link

Push with failures - Wr
Push with failures - wpt
Push with failures - bc

Failure log - Wr
Failure log - wpt
Failure log - bc

Comment 6

[Sean Feng [:sefeng][PTO, back July 1st]]

Attachment: Bug 1811129 - Update quicksuggestOnboarding.html to reflect the latest <dialog> focusing algorithm changes r=adw

Given the <dialog> itself becomes focusable, the expected focusing
order has been changed.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94d3ff1570f4
Implement the new dialog initial focus algorithm r=emilio
https://hg.mozilla.org/integration/autoland/rev/f41311ee4ade
Update quicksuggestOnboarding.html to reflect the latest <dialog> focusing algorithm changes r=adw

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41289 for changes under testing/web-platform/tests

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/94d3ff1570f4
https://hg.mozilla.org/mozilla-central/rev/f41311ee4ade

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot