1701493 - [Proton] The drop-down background of the select box in the extension inline options page is transparent.

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P2)

Description

[nayinain]

Attachment: Capture.webm

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

1. Set browser.proton.contextmenus.enabled to true in about:config and restart Nightly.
2. Install the extension (https://addons.mozilla.org/en-US/firefox/addon/traduzir-paginas-web/)
3. Open the options of the extension in the about:addons page.
4. lick to open the select box drop-down on the options page.

Actual results:

The drop-down background is transparent.

---

Sorry for my bad English.

Comment 1

[:Gijs (he/him)]

Bug 1692237 broke this.

It looks like the styles at https://searchfox.org/mozilla-central/source/toolkit/themes/windows/global/popup.css#169-176 are applying, but the styles at https://searchfox.org/mozilla-central/rev/d58860eb739af613774c942c3bb61754123e449b/toolkit/themes/windows/global/popup.css#51 are missing the variable definitions, so the CSS variables are not resolving, which is breaking the styling. Although the menupopup itself pulls in global.css which defines these variables, they're defined on :root which is having no effect when loaded into shadow DOM. Also defining the variables on :host fixes this.

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1701493 - make menulist dropdowns in about:addons' add-on options not look completely broken, r?mstriemer

More details in https://bugzilla.mozilla.org/show_bug.cgi?id=1701493#c1 .

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1692237

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72593dfc1e16
make menulist dropdowns in about:addons' add-on options not look completely broken, r=mstriemer

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/72593dfc1e16

Comment 6

[Bogdan Maris, Desktop Test Engineering]

Reproduced the initial issue using an old Nightly 2021-03-28, verified that this is now fixed using latest Nightly 89.0a1 across platforms (Windows 10, macOS 11.3 and Ubuntu 18.04).