1703810 - [Proton] Items inside about:preferences dropdowns are not visible with dark theme set in Windows 10

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P1)

Description

[Bogdan Maris, Desktop QA]

Affected versions

• Nightly 89.0a1

Affected platforms

• Windows 10

Steps to reproduce

1. Make sure to have dark theme enabled in Windows 10
2. Start Firefox
3. Go to about:preferences#search
4. Click the Default Search Engine dropdown

Expected result

• Items in the dropdown are visible and respect the dark theme set in the OS.

Actual result

• Dropdown is white and the items are also in white text, making them invisible. They are visible only when hovering over them or going through them using arrow keys.

Regression range

• First bad: 72593dfc1e16b16ef11770d9e01a970d0e116d6f
• Last good: a5a265c2b2a5fa906275ffb8a1910c3e734bc76b
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a5a265c2b2a5fa906275ffb8a1910c3e734bc76b&tochange=72593dfc1e16b16ef11770d9e01a970d0e116d6f
• Potential regressor: Bug 1701493 - [Proton] The drop-down background of the select box in the extension inline options page is transparent.

Additional notes

• Screenshot showing the issue is attached.
• Having Light theme set in OS does not show this issue.

Suggested severity

• I would say this is S2 severity because none of the items inside dropdowns can be seen and this is a recent regression.

Comment 1

[Bogdan Maris, Desktop QA]

Attachment: Screenshot showing the issue

Comment 2

[:Gijs (he/him)]

Gah, :host:foo not working but :host(:foo) working is going to keep tripping me up for a while (and looks like I'm not the only one, https://searchfox.org/mozilla-central/rev/5a8487d8e9dd114289083800f723d9c56c9a8003/toolkit/components/certviewer/content/components/info-group.css#14 also doesn't look like it'd work?). Would be nice if we had CSS linting but sadly that's blocked by bug 1659444.

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1703810 - fix OS dark mode application in in-content page menulists on Windows 10, r?jaws

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9816fa9442d6
fix OS dark mode application in in-content page menulists on Windows 10, r=jaws

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/9816fa9442d6

Comment 6

[Bogdan Maris, Desktop QA]

Verified that this is fixed using latest Nightly 89.0a1.