Closed Bug 1701629 Opened 5 years ago Closed 5 years ago

DRM indicator should not be styled as a chiclet

Categories

(Firefox :: Address Bar, defect, P2)

Product:
Firefox
Component:
Address Bar
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed

People

(Reporter: mak, Assigned: mak)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-address-bar] [priority:2b])

Attachments

(3 files)

notifications
16.18 KB, image/png
Details
password changed
16.75 KB, image/png
Details
Bug 1701629 - Make notification icons style closer to other urlbar icons. r=mconley
48 bytes, text/x-phabricator-request
Details | Review

The DRM indicator in the urlbar is styles as a chiclet, it should be styled as a normal urlbar icon.
It can be tested at https://bitmovin.com/demos/drm

It's not even exactly a chiclet since it doesn't react to focus, sounds like we just missed updating it

This affects other icons in the address bar as well. I saw the same already for the website notifications icon, for the icon when updating the password and when installing an add-on.

Whiteboard: [proton-address-bar] → [proton-address-bar] [priority:2a]
Assignee: nobody → mak
Status: NEW → ASSIGNED

(In reply to Sören Hentzschel from comment #2)

This affects other icons in the address bar as well. I saw the same already for the website notifications icon, for the icon when updating the password and when installing an add-on.

Please provide screenshots, if the button is "open" (showing a panel) it is expected to have a background. This is about the default background.

Flags: needinfo?(soeren.hentzschel)
Attached image notifications —
Flags: needinfo?(soeren.hentzschel)
Attached image password changed —

You can ignore "when installing an add-on" because the panel is always opened in this case but for notifications and the "change password" case the background is there even if the panel is not opened.

Bug 1701664 has partially fixed this, it didn't add an :hover state though, afaict. I'll do a second pass over it.

Thank you for the screenshots, I actually think bug 1701664 has resolved those too.

Depends on: 1701664
Attachment #9214030 - Attachment description: Bug 1701629 - DRM indicator should not be styled as a chiclet. r=mconley → Bug 1701629 - Make notification icons style closer to other urlbar icons. r=mconley
Whiteboard: [proton-address-bar] [priority:2a] → [proton-address-bar] [priority:2b]
Blocks: 1703659
Attachment #9214030 - Attachment description: Bug 1701629 - Make notification icons style closer to other urlbar icons. r=mconley → Bug 1701629 - DRM indicator should not be styled as a chiclet. r=mconley
Attachment #9214030 - Attachment description: Bug 1701629 - DRM indicator should not be styled as a chiclet. r=mconley → Bug 1701629 - Make notification icons style closer to other urlbar icons. r=mconley
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/209696ddb4c6 Make notification icons style closer to other urlbar icons. r=mconley

https://hg.mozilla.org/mozilla-central/rev/209696ddb4c6

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Regressions: 1711215
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: