DRM indicator should not be styled as a chiclet
Categories
(Firefox :: Address Bar, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | fixed |
People
(Reporter: mak, Assigned: mak)
References
(Blocks 1 open bug)
Details
(Whiteboard: [proton-address-bar] [priority:2b])
Attachments
(3 files)
notifications
The DRM indicator in the urlbar is styles as a chiclet, it should be styled as a normal urlbar icon.
It can be tested at https://bitmovin.com/demos/drm
|
||
Updated•3 years ago
|
|
Assignee | |
Comment 1•3 years ago
|
||
It's not even exactly a chiclet since it doesn't react to focus, sounds like we just missed updating it
|
||
Comment 2•3 years ago
|
||
This affects other icons in the address bar as well. I saw the same already for the website notifications icon, for the icon when updating the password and when installing an add-on.
|
||
Updated•3 years ago
|
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 3•3 years ago
|
||
(In reply to Sören Hentzschel from comment #2)
This affects other icons in the address bar as well. I saw the same already for the website notifications icon, for the icon when updating the password and when installing an add-on.
Please provide screenshots, if the button is "open" (showing a panel) it is expected to have a background. This is about the default background.
|
|
||
Comment 4•3 years ago
|
||
|
|
||
Comment 5•3 years ago
|
||
|
|
||
Comment 6•3 years ago
|
||
You can ignore "when installing an add-on" because the panel is always opened in this case but for notifications and the "change password" case the background is there even if the panel is not opened.
|
|
Assignee | |
Comment 7•3 years ago
•
|
||
Bug 1701664 has partially fixed this, it didn't add an :hover state though, afaict. I'll do a second pass over it.
Thank you for the screenshots, I actually think bug 1701664 has resolved those too.
|
|
Assignee | |
Comment 8•3 years ago
|
||
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/209696ddb4c6 Make notification icons style closer to other urlbar icons. r=mconley
|
||
Comment 10•3 years ago
|
||
| bugherder | ||
Description
•