1701678 - [Proton] Translation notification bar is broken

Status: VERIFIED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect)

Description

[nayinain]

Attachment: Screenshots.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

1. Set browser.proton.infobars.enabled, browser.translation.detectLanguage and browser.translation.ui.showtotrueinabout:config`.
2. Restart Nightly.
3. Open https://www.baidu.com/

Actual results:

The translation notification bar is broken.

Comment 1

[nayinain]

Regression window:

2021-03-29T22:37:08.294000: INFO : application_version: 89.0a1
2021-03-29T22:37:08.297000: INFO : platform_buildid: 20210329023619
2021-03-29T22:37:08.297000: INFO : platform_changeset: 12ad213232f380306f4d245504c0c7211a44f091
2021-03-29T22:37:08.297000: INFO : platform_repository: https://hg.mozilla.org/integration/autoland
2021-03-29T22:37:08.297000: INFO : platform_version: 89.0a1
2021-03-29T22:37:17.898000: INFO : Narrowed integration regression window from [5682b038, 512780b9] (3 builds) to [12ad2132, 512780b9] (2 builds) (~1 steps left)
2021-03-29T22:37:17.911000: DEBUG : Starting merge handling...
2021-03-29T22:37:17.911000: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=512780b9dd3ccbd9457fdcc9ccfbc412c9d87fef&full=1
2021-03-29T22:37:17.912000: DEBUG : redo: attempt 1/3
2021-03-29T22:37:17.912000: DEBUG : redo: retry: calling _default_get with args: ('https://hg.mozilla.org/integration/autoland/json-pushes?changeset=512780b9dd3ccbd9457fdcc9ccfbc412c9d87fef&full=1',), kwargs: {}, attempt #1
2021-03-29T22:37:17.916000: DEBUG : urllib3.connectionpool: Resetting dropped connection: hg.mozilla.org
2021-03-29T22:37:19.338000: DEBUG : urllib3.connectionpool: https://hg.mozilla.org:443 "GET /integration/autoland/json-pushes?changeset=512780b9dd3ccbd9457fdcc9ccfbc412c9d87fef&full=1 HTTP/1.1" 200 None
2021-03-29T22:37:19.390000: DEBUG : Found commit message:
Bug 1690333 - Proton infobar styles r=jaws

Differential Revision: https://phabricator.services.mozilla.com/D104585

2021-03-29T22:37:19.391000: DEBUG : Did not find a branch, checking all integration branches
2021-03-29T22:37:19.396000: INFO : The bisection is done.
2021-03-29T22:37:19.400000: INFO : Stopped

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1690333

Comment 3

[Sören Hentzschel]

Please note that the Bergamot extension [1] requires browser.proton.enabled set to be true so ideally this should be fixed before the infobars graduate to the main Proton preference (bug 1702330).

[1] https://github.com/mozilla-extensions/bergamot-browser-extension

Comment 4

[Mark Striemer [:mstriemer]]

There's a fix for this in bug 1702327 (it just leaves this infobar with the old styling since it's very custom compared to the other infobars).

Comment 5

[Mark Striemer [:mstriemer]]

This should now be fixed by bug 1702327

Comment 6

[Simona Badau, Desktop QA]

Attachment: Screenshot with the Translation Infobar position.png

Verified using the latest Firefox 89 beta 2 and the latest Nightly 90.0a1 - the translation infobar is displayed with the old style. Verified on macOS BigSur 11.2, Windows 10 x64, and Ubuntu 20.04 x64.

However, during verification, I noticed some situations in which the Translation infobar can change position and is affecting the stacking and Proton design (please see the screenshot). Mark, is this behavior expected?

Comment 7

[Mark Striemer [:mstriemer]]

What do you mean by "change position"? I see the translation bar is first in the first screenshot, then second. Are you saying that it initially appeared at the top then moved on its own to the bottom? I'd expect it to be the lowest infobar when it appears, and opening a new (tab-specific) infobar would appear under it. If you had the first screenshot, then close and retriggered the translation infobar I would expect it to move like that

Comment 8

[Simona Badau, Desktop QA]

(In reply to Mark Striemer [:mstriemer] from comment #7)

What do you mean by "change position"? I see the translation bar is first in the first screenshot, then second. Are you saying that it initially appeared at the top then moved on its own to the bottom? I'd expect it to be the lowest infobar when it appears, and opening a new (tab-specific) infobar would appear under it. If you had the first screenshot, then close and retriggered the translation infobar I would expect it to move like that

Ok, so basically I'm seeing the intended behavior. And no, it doesn't move by itself. If I open the translation infobar first and then another tab specific, this will be placed under the translation, and vice-versa (the translation one is placed under another tab specific infobar if it's triggered secondly).

What I wasn't expecting was to see the translation infobar between the 2 other proton-styled info bars. I would have expected for it to be somehow separated by the proton-styled ones (maybe always on the bottom, since the browser-specific ones are always on top). At the time being, especially when the translation infobar is in the middle everything seems out of place as the buttons and the text is bigger and differently styled. Do you know if the translation infobar will be reworked in the near future?

Comment 9

[Mark Striemer [:mstriemer]]

We have bug 1703322 on file to update the translation bar to proton styling. I haven't heard anything about prioritising that right now and I suspect it would be out of scope for proton

Comment 10

[Simona Badau, Desktop QA]

(In reply to Mark Striemer [:mstriemer] from comment #9)

We have bug 1703322 on file to update the translation bar to proton styling. I haven't heard anything about prioritising that right now and I suspect it would be out of scope for proton

Great, thanks, Mark!

Based on Comment 6 and Comment 7, setting the status of this to Verified fixed.