1701704 - Manage logins… shouldn't use ellipsis

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect)

Description

[Francesco Lodolo [:flod]]

The Manage Logins… menu item doesn't require any interaction to complete, it just opens the page. Hence it shouldn't have the ellipsis, and just be "Manage Logins".

This was introduced in bug 1692322. Unfortunately, it requires a new string ID and retranslation.

See updated slide
https://docs.google.com/presentation/d/1Ufd0A3HsziyXXAjXYNH84P2bu7RdTxARsA0xpKmwIWs/edit?ts=6061fe30#slide=id.gb7754f26c5_10_79

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Bug 1701704 - Remove ellipsis from Manage Logins label in context menu, r=sfoster!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49439a69910b
Remove ellipsis from Manage Logins label in context menu, r=sfoster

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/49439a69910b

Comment 4

[Giorgia Nichita, Release Desktop QA]

Hello,
I have reproduced the issue using STR from comment 0, on an affected Nightly build 2021-03-28.

The fix was verified using the latest Nightly 90.0a1 (2021-05-09) and Firefox 89.0b9 (2021-05-06) on Windows 10x64, Ubuntu 20.04 and macOS 10.15.
The issue is not reproducing anymore.

Thanks!