1701908 - Partial OpenPGP encryption reminder might be shown for an unrelated message

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Kai Engert (:KaiE:)]

Bug 1672851 introduced variable showPartialDecryptionReminder in enigmailMessengerOverlay.js.

In certain situations, this may cause an OpenPGP reminder notification to be shown for an unrelated messages.

The fix is to clear the variable in messageCleanup().

Comment 1

[Kai Engert (:KaiE:)]

Attachment: Bug 1701908 - Avoid showing partial encryption reminder for an unrelated message. r=aleca

Comment 2

[Kai Engert (:KaiE:)]

Attachment: 1701908-v1.patch

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9212579 [details] [diff] [review]
1701908-v1.patch

Review of attachment 9212579 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable. r+

Comment 4

[Magnus Melin [:mkmelin]]

Should this land?

Comment 5

[Kai Engert (:KaiE:)]

I'd prefer to land bug 1701908, bug 1701924, bug 1702582 and bug 1673241 in a single commit, they are all closely related, to avoid new complaints about new incorrect scenarios.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fb58f853384a
Avoid showing partial encryption reminder for an unrelated message. r=aleca

Comment 7

[Kai Engert (:KaiE:)]

Comment on attachment 9212579 [details] [diff] [review]
1701908-v1.patch

[Approval Request Comment]
Regression caused by (bug #): 1672851
User impact if declined: a helpful reminder not shown
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): low

Comment 8

[Kai Engert (:KaiE:)]

Comment on attachment 9212579 [details] [diff] [review]
1701908-v1.patch

[deleted, was empty]

Comment 9

[Kai Engert (:KaiE:)]

See above beta approval request for details.

Requesting esr78 approval, however, should wait for at least 2 weeks beta testing.

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9212579 [details] [diff] [review]
1701908-v1.patch

[Triage Comment]
Approved for beta

Comment 11

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/releases/comm-beta/rev/ad292a0fe88aadc622124410e4388df68b629fae
89.0b3

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9212579 [details] [diff] [review]
1701908-v1.patch

[Triage Comment]
Approved for esr78

Comment 13

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/releases/comm-esr78/rev/328f894a968cf8583aa6f7f0dc1db8c39df00706
78.10.2