Closed Bug 1702293 Opened 3 years ago Closed 3 years ago

Fix bookmarks dialog spacing and other styling issues

Categories

(Firefox :: Bookmarks & History, defect, P2)

defect

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: mtigley, Assigned: mtigley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-modals] [priority:2c])

Attachments

(3 files)

The expander button for the bookmarks dialog should match the spec.

Severity: -- → S3
See Also: → 1702249
Whiteboard: [proton-modals]
Whiteboard: [proton-modals] → [proton-modals] [priority:2c]
Priority: -- → P2
Assignee: nobody → mtigley
Status: NEW → ASSIGNED
Attachment #9214236 - Attachment description: WIP: Bug 1702293 - Reuse bookmarks panel styles in bookmarks dialog. → Bug 1702293 - Reuse bookmarks panel styles in bookmarks dialog. r?Gijs,mconley

Here is what I'm seeing in Nightly.
Is good here or do I need to open a separate bug?

Operating System: openSUSE Tumbleweed 20210406
KDE Plasma Version: 5.21.3
KDE Frameworks Version: 5.80.0
Qt Version: 5.15.2
Kernel Version: 5.11.11-1-default
OS Type: 64-bit
Graphics Platform: X11
Processors: 8 × Intel® Core™ i7-4810MQ CPU @ 2.80GHz
Memory: 31.0 GiB of RAM
Graphics Processor: Mesa DRI Intel® HD Graphics 4600

Attachment #9214236 - Attachment description: Bug 1702293 - Reuse bookmarks panel styles in bookmarks dialog. r?Gijs,mconley → Bug 1702293 - Reuse bookmarks panel styles in bookmarks dialog. r?mconley
Attachment #9214236 - Attachment description: Bug 1702293 - Reuse bookmarks panel styles in bookmarks dialog. r?mconley → Bug 1702293 - Copy bookmarks panel styles for the bookmarks dialog. r?mconley
Blocks: 1704583
Blocks: 1702249
Blocks: 1704880
Summary: Fix the expander button styling in the bookmarks dialog → Fix bookmarks dialog spacing and other styling issues
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f40a82f52d42
Copy bookmarks panel styles for the bookmarks dialog. r=mconley
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

If I edit an existing bookmark, I'm still seeing the issue in Nightly

(In reply to jonzn4SUSE from comment #6)

Created attachment 9216033 [details]
bookmark expander_Screenshot_20210415_050159.jpeg

If I edit an existing bookmark, I'm still seeing the issue in Nightly

Bugs get marked fixed when the patches merge to the mainline development branch (mozilla-central), but nightlies for today (that would include the fixes in this bug) haven't been built yet. Please try again when you get today's nightly.

Yes, all is well.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: