1693139 - Update bookmark dialogs for proton

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, enhancement, P1)

Description

[:Gijs (he/him)]

These dialogs should:

• open as an in-window modal dialog
• show a star icon on the top left when creating a new item (folder / bookmark), see bug 1693008, and the bookmark's icon if editing an existing bookmark with a favicon;
• show a "Save" button as the accept button
• folder dialogs should show titles of "Add bookmarks folder" and "Edit bookmarks folder" (depending on whether the item is new)
• drop the : after field labels
• re-label "Location" as "URL"
• show a smaller, grey-ish text under the tags field with "Use tags to organize and search for bookmarks from the address bar", and similarly "Use keywords to open bookmarks directly from the address bar" under the keywords field.

Comment 1

[:Gijs (he/him)]

There's still some open questions here around Save vs. Add for buttons. I'll try and get those resolved.

Comment 2

[:Gijs (he/him)]

One day, I will manage to keep a needinfo I want to keep. Or perhaps we can teach bugzilla not to clear them automatically or something...

Comment 3

[:Gijs (he/him)]

OK, we're sticking with "Save" for buttons.

Also, the add/edit bookmark dialog should have the title "Add bookmark" and "Edit bookmark", respectively (no need to quote/copy the bookmark name/title).

Text and design specs are both in figma now.

Comment 4

[:Gijs (he/him)]

Update priority to reflect proton priorities.

Comment 5

[Micah [:mtigley] (she/her)]

Attachment: Bug 1693139 - Open bookmarks dialogs with in-window modal, plus some styling to input fields. r?gijs!

Comment 6

[Micah [:mtigley] (she/her)]

Attachment: Bug 1693139 - Update title strings for input fields in editBookmarkPanel. r?gijs!

Depends on D108870

Comment 7

[Micah [:mtigley] (she/her)]

Attachment: Bug 1693139 - Add label captions for tags and keyword fields. r?gijs!

Depends on D108871

Comment 8

[Micah [:mtigley] (she/her)]

Attachment: Bug 1693139 - Update bookmark dialog titles to show icons. r?gijs!

Depends on D108872

Comment 9

[Micah [:mtigley] (she/her)]

try push: https://treeherder.mozilla.org/jobs?repo=try&revision=79e8cedc2e5009a325b381628a9b64bca61e6b8b

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4e16239c273
Open bookmarks dialogs with in-window modal, plus some styling to input fields. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/49fdb99ba738
Update title strings for input fields in editBookmarkPanel. r=Gijs,fluent-reviewers
https://hg.mozilla.org/integration/autoland/rev/e926ee8c269c
Add label captions for tags and keyword fields. r=Gijs,fluent-reviewers
https://hg.mozilla.org/integration/autoland/rev/8040add982c0
Update bookmark dialog titles to show icons. r=Gijs

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/e4e16239c273
https://hg.mozilla.org/mozilla-central/rev/49fdb99ba738
https://hg.mozilla.org/mozilla-central/rev/e926ee8c269c
https://hg.mozilla.org/mozilla-central/rev/8040add982c0

Comment 12

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Attachment: keyword.JPG

Gijs,

It's reading: Use a single keyword to open bookmkarks directly from the address bar
As opposed to: "Use keywords to open bookmarks directly from the address bar" under the keywords field.

Is this alright?
Best regards,
Clara

Comment 13

[Micah [:mtigley] (she/her)]

Hi Clara, yes we made this change in Bug 1705535 to account for the issue where the "Keyword" field only accepts one keyword input.

Comment 14

[:Gijs (he/him)]

Micah answered this.

Comment 15

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Great, in that case I'll update the flags accordingly.
This has been verified in latest both beta and nightly builds. (Nightly 90.0a1 (2021-05-05) (64-bit) and Beta 89.0b8 (64-bit)) for Mac0s 11.4, Ubuntu 20.04, and Windows 10 pro.
Best regards,
Clara