1702249 - Fix spacing in the bookmarks dialog

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[:Gijs (he/him)]

Attachment: Screenshot 2021-03-31 at 15.52.59.png

The spacing and alignment in the bookmarks dialog still needs some work.

The vertical spacing should be 4px between each label and the corresponding input field below it. Each "row" of a label, and input field, and a description underneath it if present, should have a 4px top and bottom padding/spacing. And between each row (and between the title and first content, and between the last content and the buttons) there should be 16px spacing (in addition to those 4px as applicable).

Horizontally, the labels should lose their inline-start margin, and the ends of the input fields should align with the end of the buttons.

It looks like the tags field doesn't get the same styling as the tags field in the bookmarks panel - I'm not sure why off-hand. (edit: now bug 1702293)

Comment 1

[:Gijs (he/him)]

Micah split the tags expander out to bug 1702293.

Comment 2

[Sören Hentzschel]

It's not explicitly mentioned in comment #0 but the alignment of the icon and the "Edit <bookmark name>" text is also off.

Comment 4

[Micah [:mtigley] (she/her)]

Copying notes from Bug 1706997 here:

Styling adjustments

Input label and text spacing and colors
• Update helper text (caption label) to use secondary color #5B5B66
• Space between label and helper text should be 4px
• Space between label and expander button should be 16px

Tags table
• Border color should be #E0E0E6
• Padding should be 12px
• Space between tags should be 8px

rtestard would be you be able to determine if this should be more than a p2b?

Comment 5

[Romain Testard [:RT]]

OK let's make it a P2a, rather low frequency of occurence makes but pretty bad looks and things seems ready to be executed so great if we can get this one done .

Comment 6

[Micah [:mtigley] (she/her)]

Attachment: Bug 1702249 - Adjust styles in bookmarks dialog. r?Gijs

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81ad8a46f34c
Adjust styles in bookmarks dialog. r=Gijs

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/81ad8a46f34c

Comment 9

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Nightly build 90.0a1 (2021-04-28).

You probably hate me by now but, I think the Edit bookmark title is like 1px or 2px lower than it should be ? should I log a separate issue for it ? Ill attach a screenshot.

Comment 10

[Rares Doghi, Desktop QA]

Attachment: EditBookmark.png

Comment 11

[Pascal Chevrel:pascalc]

Micah, you can request an uplift to beta? Thanks

Comment 12

[:Gijs (he/him)]

(In reply to Rares Doghi from comment #9)

You probably hate me by now

Nope! Thank you for all you do.

but, I think the Edit bookmark title is like 1px or 2px lower than it should be ?

Or, conversely, the icon is too high. :-)

But yes, you are right.

should I log a separate issue for it ? Ill attach a screenshot.

No, don't bother filing another ticket. It's also too high in the main content JS dialogs, and checkboxes are also more out-of-line now. It's because we reversed the font-size changes, so the text is smaller. I'm investigating in bug 1707538. Once I have something there we'll have to re-verify the icons and checkboxes in this and other dialogs.

Comment 13

[Rares Doghi, Desktop QA]

Great!

Comment 14

[Micah [:mtigley] (she/her)]

Comment on attachment 9217822 [details]
Bug 1702249 - Adjust styles in bookmarks dialog. r?Gijs

Beta/Release Uplift Approval Request

• User impact if declined: Required for MR1 / Proton
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Spacing adjustments to bookmarks dialog
• String changes made/needed:

Comment 15

[Pascal Chevrel:pascalc]

Comment on attachment 9217822 [details]
Bug 1702249 - Adjust styles in bookmarks dialog. r?Gijs

Approved for 89 beta 7, thanks.

Comment 16

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/8be4643c5761

Comment 17

[Rares Doghi, Desktop QA]

This issue is Verified as fixed in Beta 89.0b7 On Windows, Mac and Ubuntu.