1702427 - [Windows 10][Proton] FirefoxColor themes that are not very dark can get dark background context menus

Status: RESOLVED DUPLICATE of bug 1760317

(Firefox :: Theme, defect, P3)

Description

[Serge]

Attachment: Color.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0

Steps to reproduce:

Enable Proton context menus

EnableProtonUI
browser.proton.enabled
browser.proton.contextmenus.enabled
browser.proton.doorhangers.enabled

Activate the following FirefoxColor theme
https://color.firefox.com/?theme=XQAAAAJyAQAAAAAAAABBKYhm849SCia6aSqEGccwS-xMDPsqvMQuvAF6DfFcVnIO2RlYPn7K96jxJl9euVMPIG3hXZanKHmO0SR6HAFypXPQodXI0IApXyo0vUL2bJ6TKo55agaySyLYVycfJRH5JWbW5mhasxmWu8vufdYBik_o42A2KoDCzaT56Bd6rOBwJgRAvXB0fdFkbgIbV8iw1NjTyaQNPYTpc0jo_tHq-a2R9pExRHQqLOaMwjpL_48SQ-GIQr_P35VJTKhJVPIbWMj_TJ1fJmfWYQlu9aX_6rYvZA

Actual results:

Context menus applied Dark theme despite the fact that it was not defined in the FirefoxColor (and Default OR Light theme is selected within Nightly)

Expected results:

Context menus should either remain unthemed (use color of the selected theme) OR Use the Popup Background and Popup Text from the FirefoxColor (because these seem to be used for all the rest popups)

Comment 1

[:Gijs (he/him)]

This is because the theme is using bright text (white, in fact) for the background of the tabstrip, which means the root element matches :-moz-lwtheme-brighttext.

I don't see what we can reasonably do about this without breaking other things.

Comment 2

[Tim Nguyen :ntim]

(In reply to :Gijs (he/him) from comment #1)

This is because the theme is using bright text (white, in fact) for the background of the tabstrip, which means the root element matches :-moz-lwtheme-brighttext.

I don't see what we can reasonably do about this without breaking other things.

Using [lwt-popup-brighttext] instead of :-moz-lwtheme-brighttext sounds potentially reasonable? or following arrowpanel color variables?

Comment 3

[:Gijs (he/him)]

(In reply to Tim Nguyen :ntim from comment #2)

Using [lwt-popup-brighttext] instead of :-moz-lwtheme-brighttext sounds potentially reasonable?

It's not really clear to me what sets that, or how it would improve things. It looks like it's mostly meant for autocomplete popups, which isn't really the same thing as a context menu...

or following arrowpanel color variables?

These don't appear to match the design so that's not an option (and changing their values would presumably change other backgrounds...).

Comment 4

[Tim Nguyen :ntim]

(In reply to :Gijs (he/him) from comment #3)

(In reply to Tim Nguyen :ntim from comment #2)

Using [lwt-popup-brighttext] instead of :-moz-lwtheme-brighttext sounds potentially reasonable?

It's not really clear to me what sets that, or how it would improve things. It looks like it's mostly meant for autocomplete popups, which isn't really the same thing as a context menu...

It's set for arrow panels too (it's the webextension theme popup color prop). The bookmarks menu is one of them. The bookmarks submenus would at least follow the bookmarks menu definition of dark/light, which would allow some consistency?

Comment 5

[CenCerberon]

Attachment: Menu of the menu bar

The menu of the menu bar is also affected.

Comment 6

[custom.firefox.lady [:tawn]]

Items in the dropdown for folders on the bookmarks toolbar also have a dark background (I'm using 'Dark Blue' theme which has a gray background for the toolbar). But the bookmarks menu button (which I also have on the toolbar) has a popup menu with a light background (which seems rather inconsistent.)

Comment 8

[Rob Wu [:robwu]]

Also reported at https://github.com/mozilla/FirefoxColor/issues/979

More reports are coming in now that Proton menus shipped to release.