1760317 - color_scheme of the theme does not control the context menu

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Anon Ymity]

Attachment: context menu

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:98.0) Gecko/20100101 Firefox/98.0

Steps to reproduce:

Windows 10 64-Bit (21H2, Build 19044.1586)
Firefox Nightly 100a1 (2022-03-18)

Setting:
Website appearance: Nightly theme

Theme:
https://addons.mozilla.org/de/firefox/addon/tiger-eyes-turquoise/

Actual results:

The context menu and the menu of the menu bar do not follow the color_scheme of the theme. They are always dark.

I can see that windows (content, about pages, library) follow the color scheme. I can make them light or dark with the theme.

Expected results:

The context menu and menu bar are also in the light theme.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Theme' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1760317 - Use prefers-color-scheme to determine windows menu color scheme. r=dao,Gijs

It's both simpler and more correct.

It prevents themes that declare themselves as light but have
bright text from getting dark menus.

This behavior matches other platforms.

Also, simplify the selectors, there's no need to use :host anymore
now that we use the same code path for <select> in the parent
process (bug 1744009).

Double-checked that this doesn't regress bug 1701493 nor
bug 1702626.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3c4aacf5575
Use prefers-color-scheme to determine windows menu color scheme. r=Gijs

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd2628f88452
Fix browser_selectpopup_colors to not read the colors too early. CLOSED TREE

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e3c4aacf5575
https://hg.mozilla.org/mozilla-central/rev/dd2628f88452

Comment 8

[Monica Chiorean]

Reproduced the issue without the fix on Win10 using build 100.0a1(20220318212951).
Verified as fixed on Win10/Mac 10.13/ Ubuntu 20.4 using build 100.0b5 (20220412185818).

Also noticed that using this theme, Customize page is transparent as on bug 1762379 (issue reproduce before this fix).