1705501 - [Windows, Fx Nightly custom theme] Various menus are unexpectedly running in dark mode after Nightly update to Proton

Status: RESOLVED DUPLICATE of bug 1750932

(Firefox :: Theme, defect, P3)

Description

[(No longer employed by Mozilla) Aaron Klotz]

Windows 10 20H2

I finally updated from a previous version of Nightly (sans Proton by default) to today's Nightly.

Previously, all my menus were in light mode.

After the update, some menus are in light mode and others are in dark mode:

• My hamburger menu is displayed in light mode;
• My bookmarks toolbar menus are displayed in dark mode;
• My right-click context menus are displayed in dark mode.

My lightweight theme is set to the "Firefox Quantum Nightly" theme that mart3ll published when we released Quantum.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

• Dropdown menus are also dark.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

• The window's main menu (ie, from pressing Alt) is also dark.

Comment 3

[:Gijs (he/him)]

(In reply to Aaron Klotz [:aklotz] from comment #0)

My lightweight theme is set to the "Firefox Quantum Nightly" theme that mart3ll published when we released Quantum.

Do you have a link to this theme to allow people to reproduce?

And if you update to today's nightly, has this improved since bug 1701691 landed (disregard the summary, that bug affected a lot more than infobars).

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

(In reply to :Gijs (he/him) from comment #3)

(In reply to Aaron Klotz [:aklotz] from comment #0)

My lightweight theme is set to the "Firefox Quantum Nightly" theme that mart3ll published when we released Quantum.

Do you have a link to this theme to allow people to reproduce?

https://addons.mozilla.org/en-US/firefox/addon/firefox-quantum-nightly/

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

(In reply to :Gijs (he/him) from comment #3)

(In reply to Aaron Klotz [:aklotz] from comment #0)
And if you update to today's nightly, has this improved since bug 1701691 landed (disregard the summary, that bug affected a lot more than infobars).

No change.

Comment 6

[jonzn4SUSE]

Attachment: Dark Mode_Screenshot_20210425_135733.jpeg

This is one bug I'm glad to see! ;-))

Comment 7

[jonzn4SUSE]

Operating System: openSUSE Tumbleweed 20210422
KDE Plasma Version: 5.21.4
KDE Frameworks Version: 5.81.0
Qt Version: 5.15.2
Kernel Version: 5.11.15-1-default
OS Type: 64-bit
Graphics Platform: X11
Processors: 8 × Intel® Core™ i7-4810MQ CPU @ 2.80GHz
Memory: 31.0 GiB of RAM
Graphics Processor: Mesa DRI Intel® HD Graphics 4600

Comment 8

[jonzn4SUSE]

Attachment: Nightly settings theme is dark_Screenshot_20210425_022435.jpeg

Comment 9

[jonzn4SUSE]

Attachment: Firefox 89.0b4_menus also in dark mode.GIF

Comment 10

[jonzn4SUSE]

Attachment: menu has gone dard_Screenshot_20210516_003728.jpeg

The menu bar is even dark.

Comment 11

[jonzn4SUSE]

Attachment: Dark menu fixed_Screenshot_20210705_014327.jpeg

The menu is now back to normal.

Comment 12

[:Gijs (he/him)]

:aklotz, can you confirm this is fixed per comment #11?

Comment 13

[:Gijs (he/him)]

Oops, I got confused. Let's clarify the summary a bit...

Comment 14

[(No longer employed by Mozilla) Aaron Klotz]

Bookmarks menus are fixed. Right-click context menus and the main menu bar are still dark.

Comment 15

[jonzn4SUSE]

Attachment: buttons are dark_Screenshot_20210807_185128.jpeg

Comment 16

[jonzn4SUSE]

Comment on attachment 9235283 [details]
buttons are dark_Screenshot_20210807_185128.jpeg

Maximize and Minimize are dark

Comment 17

[loic.yavorsky]

Have the same bug with min/max buttons, also with the close button; see attached

Comment 18

[loic.yavorsky]

https://ibb.co/y5wVqTn

Comment 19

[:Gijs (he/him)]

jonzn4SUSE/loic: this bug is specifically about menus, and about Windows 10. You both appear to have issues with caption buttons on Linux. Please file a separate new bug for that.

Comment 20

[(No longer employed by Mozilla) Aaron Klotz]

As far as I can tell, this is now spilling over into content: I'm getting website content in dark mode because the toolbars are perceived to be in dark mode.

Comment 21

[:Gijs (he/him)]

(In reply to (No longer employed by Mozilla) Aaron Klotz from comment #20)

As far as I can tell, this is now spilling over into content: I'm getting website content in dark mode because the toolbars are perceived to be in dark mode.

This is tracked in bug 1736218, and is a result of mostly unrelated other work.

Comment 22

[CenCerberon]

Attachment: Firefox Linux.png

I am not sure if the bug is really limited to Windows.
I can reproduce the bug with the same theme on Windows and Linux.

Theme:
https://addons.mozilla.org/de/firefox/addon/tiger-eyes-turquoise/

openSUSE Leap 15.3
Firefox 91.4.0esr (64-Bit)

Windows 10 21H2
Firefox 95.0 (64-Bit)

Comment 23

[:Gijs (he/him)]

(In reply to CenCerberon from comment #22)

Created attachment 9255224 [details]
Firefox Linux.png

Linux is sufficiently different from Windows here in how the theming works that this is really best tracked in a separate bug. On Linux we rely on GTK theming to start with (at least for native menus), and on Windows 10/11 we've stopped relying on the OS for theming completely because it looks crummy - except in high-contrast mode. Either way, the root cause for your issue on Linux is probably different, and it'd be worth checking if it still reproduced on a non-ESR version and then filing a separate bug with that info and that screenshot.

Comment 24

[CenCerberon]

Both firefox react in the same way. The menu becomes dark when the font color of the tab is white or light.

The reporter also used a theme with light font color.
https://addons.mozilla.org/de/firefox/addon/firefox-quantum-nightly/

Is this bug perhaps a duplicate of Bug 1702427?