Closed
Bug 1702541
Opened 4 years ago
Closed 4 years ago
Ensure browser/extensions/screenshots/background/startBackground.js passes eslint check
Categories
(Firefox :: Screenshots, enhancement, P3)
Firefox
Screenshots
Tracking
()
RESOLVED
FIXED
89 Branch
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | fixed |
People
(Reporter: emmamalysz, Assigned: falgunimst95)
References
Details
(Whiteboard: [outreachy-2021-screenshots])
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1702532 +++
We should fix these errors in order to enable eslint in the screenshots directory.
To find the errors:
- Temporarily comment out https://searchfox.org/mozilla-central/rev/4fa18c26fa907f38d56b599571b9846af1506f3c/.eslintignore#43-45
- Run
./mach lint browser/extensions/screenshots/background/startBackground.js
First, check if this can receive an automatic fix via:
./mach lint browser/extensions/screenshots/background/startBackground.js --fix.
Otherwise, investigate the failures and see if it requires a manual fix
|
Reporter | |
Updated•4 years ago
|
Severity: -- → S4
Priority: -- → P3
|
|
Reporter | |
Updated•4 years ago
|
Whiteboard: [outreachy-2021-screenshots]
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
Assignee: nobody → falgunimst95
Status: NEW → ASSIGNED
|
|
||
Updated•4 years ago
|
Attachment #9213432 -
Attachment description: WIP: Bug 1702541: fix eslint check pass browser/extensions/screenshots/background/startBackground.js → Bug 1702541: fix eslint check passes browser/extensions/screenshots/background/startBackground.js
|
|
||
Updated•4 years ago
|
Attachment #9213432 -
Attachment description: Bug 1702541: fix eslint check passes browser/extensions/screenshots/background/startBackground.js → Bug 1702541: fix eslint browser/extensions/screenshots/background/startBackground.js
|
|
||
Updated•4 years ago
|
Attachment #9213432 -
Attachment description: Bug 1702541: fix eslint browser/extensions/screenshots/background/startBackground.js → Bug 1702541: fix eslint passes check browser/extensions/screenshots/background/startBackground.js
|
|
||
Updated•4 years ago
|
Attachment #9213432 -
Attachment description: Bug 1702541: fix eslint passes check browser/extensions/screenshots/background/startBackground.js → Bug 1702541: fix eslint browser/extensions/screenshots/background/startBackground.js
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8b338b5407e4
fix eslint browser/extensions/screenshots/background/startBackground.js r=emalysz
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox89:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•