Closed Bug 1682719 Opened 4 years ago Closed 4 years ago

[meta] Enable eslint on browser/extensions/screenshots

Categories

(Firefox :: Screenshots, enhancement, P3)

Product:
Firefox
Component:
Screenshots
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
90 Branch
Tracking Flags:
Tracking Status
firefox90 --- fixed

People

(Reporter: sfoster, Assigned: kajalsah107)

References

Details

(Keywords: meta)

Attachments

(1 file, 2 obsolete files)

Bug 1682719 - [meta] Enables eslint on browser/extensions/screenshots. r?emalysz
48 bytes, text/x-phabricator-request
Details | Review

As this extension used to be maintained outside of the tree, we currently have this whole directory ignored by eslint

There's still a lot of dead/orphaned code in there, but we should be able to get this to pass and un-ignore it once its had some cleanup. Or at least ignore only specific files/directories.

Severity: -- → S4
Priority: -- → P3

I had submit the patch @sfoster can you assign it to me?

Assignee: nobody → falgunimst95
Status: NEW → ASSIGNED
Depends on: 1702532
No longer depends on: 1702532
Summary: Enable eslint on browser/extensions/screenshots → [meta] Enable eslint on browser/extensions/screenshots
Depends on: 1702533
Depends on: 1702532
Depends on: 1702535
Depends on: 1702536
Depends on: 1702537
Depends on: 1702538
Depends on: 1702539
Depends on: 1702540
Depends on: 1702541
Depends on: 1702542
Depends on: 1702543
Depends on: 1702545
Depends on: 1702555
Depends on: 1702556
Depends on: 1702557
Depends on: 1702558
Depends on: 1702559
Depends on: 1702562
Depends on: 1702564
Depends on: 1702565
Depends on: 1702567
Depends on: 1702568
Depends on: 1702569
Depends on: 1702570
Depends on: 1702572
Depends on: 1702573
Depends on: 1702574
Depends on: 1702575
Depends on: 1702576
Depends on: 1702577
Depends on: 1702578
Depends on: 1702579

I'm going to unassign Falguni until dependencies have been resolved

Status: ASSIGNED → NEW
Assignee: falgunimst95 → nobody
Assignee: nobody → kajalsah107
Status: NEW → ASSIGNED

My patch solves automatic fixes by eslint. Most of the remaining 68 errors are of type XXX is not defined. For example. browser not defined in browser/extensions/screenshots/assertIsBlankDocument.js. Any suggestions on how this can be tackled?

Attachment #9212865 - Attachment is obsolete: true
Attachment #9213255 - Attachment is obsolete: true
Assignee: kajalsah107 → nobody
Status: ASSIGNED → NEW

This bug is intended to track the progress in the browser/extensions/screenshots directory. Please take a bug from the dependency list

Assignee: nobody → kajalsah107
Status: NEW → ASSIGNED
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a81431c752a6 [meta] Enables eslint on browser/extensions/screenshots. r=emalysz

https://hg.mozilla.org/mozilla-central/rev/a81431c752a6

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox90: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: