[meta] Enable eslint on browser/extensions/screenshots
Categories
(Firefox :: Screenshots, enhancement, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox90 | --- | fixed |
People
(Reporter: sfoster, Assigned: kajalsah107)
References
Details
(Keywords: meta)
Attachments
(1 file, 2 obsolete files)
As this extension used to be maintained outside of the tree, we currently have this whole directory ignored by eslint
There's still a lot of dead/orphaned code in there, but we should be able to get this to pass and un-ignore it once its had some cleanup. Or at least ignore only specific files/directories.
Reporter | ||
Updated•3 years ago
|
Comment 1•3 years ago
|
||
Comment 2•3 years ago
|
||
I had submit the patch @sfoster can you assign it to me?
Updated•3 years ago
|
Updated•3 years ago
|
Comment 3•3 years ago
|
||
I'm going to unassign Falguni until dependencies have been resolved
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
My patch solves automatic fixes by eslint. Most of the remaining 68 errors are of type XXX
is not defined. For example. browser not defined in browser/extensions/screenshots/assertIsBlankDocument.js. Any suggestions on how this can be tackled?
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Comment 6•3 years ago
|
||
This bug is intended to track the progress in the browser/extensions/screenshots directory. Please take a bug from the dependency list
Updated•3 years ago
|
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a81431c752a6 [meta] Enables eslint on browser/extensions/screenshots. r=emalysz
Comment 9•3 years ago
|
||
bugherder |
Description
•