Closed Bug 1702577 Opened 3 years ago Closed 3 years ago

Ensure browser/extensions/screenshots/test/browser/browser_screenshot_button.js passes eslint check

Categories

(Firefox :: Screenshots, enhancement, P3)

Product:
Firefox
Component:
Screenshots
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed

People

(Reporter: emmamalysz, Assigned: falgunimst95)

References

Details

(Whiteboard: [outreachy-2021-screenshots])

Attachments

(1 file)

Bug 1702577: fix passes eslint check browser/extensions/screenshots/test/browser/browser_screenshot_button.js
48 bytes, text/x-phabricator-request
Details | Review

+++ This bug was initially created as a clone of Bug #1702532 +++

We should fix these errors in order to enable eslint in the screenshots directory.

To find the errors:

  1. Temporarily comment out https://searchfox.org/mozilla-central/rev/4fa18c26fa907f38d56b599571b9846af1506f3c/.eslintignore#43-45
  2. Run ./mach lint browser/extensions/screenshots/test/browser/browser_screenshot_button.js

First, check if this can receive an automatic fix via:
./mach lint browser/extensions/screenshots/test/browser/browser_screenshot_button.js --fix.

Otherwise, investigate the failures and see if it requires a manual fix

Whiteboard: [outreachy-2021-screenshots]
Assignee: nobody → falgunimst95
Status: NEW → ASSIGNED
Attachment #9213415 - Attachment description: WIP: Bug 1702577: fix the eslint check pass browser/extensions/screenshots/test/browser/browser_screenshot_button.js → Bug 1702577: fix eslint check pass browser/extensions/screenshots/test/browser/browser_screenshot_button.js
Attachment #9213415 - Attachment description: Bug 1702577: fix eslint check pass browser/extensions/screenshots/test/browser/browser_screenshot_button.js → Bug 1702577: fix eslint browser/extensions/screenshots/test/browser/browser_screenshot_button.js
Attachment #9213415 - Attachment description: Bug 1702577: fix eslint browser/extensions/screenshots/test/browser/browser_screenshot_button.js → Bug 1702577: fix passes eslint check browser/extensions/screenshots/test/browser/browser_screenshot_button.js
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e72c8df365db
fix passes eslint check browser/extensions/screenshots/test/browser/browser_screenshot_button.js r=emalysz

https://hg.mozilla.org/mozilla-central/rev/e72c8df365db

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: