1703008 - Some folder tree and icon colours are wrong in the Bookmarks Panel with Dark Theme enabled

Status: NEW

(Firefox :: Bookmarks & History, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

Specifically, the icons for the expanders, the menulist dropdown icon, the new folder icon, and the tree twisties in the folder selector.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

So I dug into this a bit, and it looks like since this bug was originally filed, the colours have been corrected for dark mode for:

• The expander icons
• The menulist icon
• The new folder button icon

However, it looks like the folder menulist still needs to be restyled. According to the panels MR1 experience review, the hover and selected states are not exactly correct. I'm going to consult with KatieC on what is expected here.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

The priority on this bug has gone down, so I'm unassigning myself from it to work on higher priority things.

Comment 3

[Itiel]

mconley, can you check if this bug is still actionable? If so, what changes are required exactly for the folder menulist?

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: image.png

Yeah, I think the issue is still here - it has to do with the selected item colour. I believe UX wanted that selected item colour to match similar selections with Dark Mode (--button-primary-hover-bgcolor).