1703026 - The Icons are missing from the Notifications Panels

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P2)

Description

[Rares Doghi, Desktop QA]

Attachment: NotificationPanels.7z

The Icons are missing from the Notifications Panels

[Affected platforms]:
Platforms: Windows 10

[Preconditions]:

Reach about:config and set browser.proton.enabled = true

[Steps to reproduce]:

1. Launch an older version of the Firefox browser.
2. Trigger the "Update and Restart", "Download Update", "Unable to Update" and "Download a Fresh Copy" panel notifications.

Expected Result:
The correct icons should be displayed on each notification panel.

Actual Results:
There are no icons displayed on any Notification panel.

Comment 1

[Shilpa Mohanty]

Hi Rares,

Is this issue still persisting?

Thanks,
Shilpa

Comment 2

[Rares Doghi, Desktop QA]

Yes, the icons are still missing from the panels in Nightly 90.0a1 (2021-04-19).

Comment 3

[Mike Conley (:mconley) (:⚙️)]

I recently updated the icons in bug 1704461, so I have some familiarity with them. I'll take this.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1703026 - Show update / warning icons in update AppMenu notification panels. r?mhowell!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ab615196f94
Show update / warning icons in update AppMenu notification panels. r=mhowell

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/6ab615196f94

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mconley, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9217898 [details]
Bug 1703026 - Show update / warning icons in update AppMenu notification panels. r?mhowell!

Beta/Release Uplift Approval Request

• User impact if declined: Required for MR1 / Proton
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a very small, well-understood change that adds the icon back to the update notification panel.
• String changes made/needed: None.

Comment 9

[Rares Doghi, Desktop QA]

Hi Mike, this is indeed fixed in our latest Nightly build but it seems that the icons are a little misaligned with the text, I did not verify each notification Icon but at least for the Unable to update notification panel the Icon is a little higher than the rest of the text, and I think the Text should be around the middle of the icon not aligned with the lower part, at least thats what I saw in Figma. Can you please take a look ?

If this bug only adds the icons back on the panels and I should log a separate one for the misaligned issues please let me know. Ill attach a screenshot of the issue.

Comment 10

[Rares Doghi, Desktop QA]

Attachment: PanelIcons.png

Comment 11

[Mike Conley (:mconley) (:⚙️)]

If this bug only adds the icons back on the panels and I should log a separate one for the misaligned issues please let me know. Ill attach a screenshot of the issue.

Yes, this is a separate issue. Could you please file a new bug?

Comment 12

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Nightly build and I logged a separate bug for the remaining issue Bug 1707826.

Comment 13

[Pascal Chevrel:pascalc]

Comment on attachment 9217898 [details]
Bug 1703026 - Show update / warning icons in update AppMenu notification panels. r?mhowell!

Approved for 89 beta 6, thanks.

Comment 14

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/5f8668a57ab7

Comment 15

[Rares Doghi, Desktop QA]

This issue is Verified as fixed in beta 89.0b7 on Mac, Windows and Ubuntu.