1704461 - update-badge.svg isn't properly horizontally centered

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Attachment: CleanShot 2021-04-12 at 11.40.20.png

The arrow in update-badge.svg isn't horizontally centered (it's too close to the right-side)
You can see in the attached screenshot that there's more space between the border of the svg and the left edge of the arrow than on the right.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1686527

Comment 2

[Romain Testard [:RT]]

Emanuela, can you please help clarify if this is a UX task to modify the asset?

Comment 3

[katieC]

Attachment: Badges - Layered SVGs - UX mini spec

The above icon isn't the correct badge for the update on the app menu icon. New badge icons have been delivered for MR1. The new "update" badge is update-circle-fill-12.svg

Please see attached image for guidance on badges or ping me on slack. Thanks!

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1704461 - Use new icons for update and warning badges for the AppMenu button. r?mhowell!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd232f359ba1
Use new icons for update and warning badges for the AppMenu button. r=mhowell

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/dd232f359ba1

Comment 8

[Rares Doghi, Desktop QA]

Hi, this issue is not entirely fixed, the Warning badge displayed on the Hamburger menu for the "Unable to update - system incompatible" notification is smaller and it looks like in your examples from Comment 3, but the same Warning badge displayed for Extensions requires new permissions is now a lot smaller and a little to the right.

Mike, Molly, can you please take a look and let me know if I should log a separate issue for the "Extensions require new permissions" warning ? I will attach a screenshot for this issue.

Comment 9

[Rares Doghi, Desktop QA]

Attachment: multiplePermissionRequests.png

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Hi Rares,

Yes, it looks like I missed a case here. Would you mind filing a new bug and cc'ing me?

Comment 11

[Rares Doghi, Desktop QA]

I will mark this issue as Verified since I added Bug 1707190 for the remaining issue.

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mconley, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 13

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9217495 [details]
Bug 1704461 - Use new icons for update and warning badges for the AppMenu button. r?mhowell!

Beta/Release Uplift Approval Request

• User impact if declined: Required for MR1 / Proton
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a reasonably simple CSS and asset-swap change only.
• String changes made/needed: None.

Comment 14

[Pascal Chevrel:pascalc]

Comment on attachment 9217495 [details]
Bug 1704461 - Use new icons for update and warning badges for the AppMenu button. r?mhowell!

Approved for 89 beta 5, thanks.

Comment 15

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/0f6dab1c3922

Comment 16

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest beta 89.0b5 on Windows 10 Mac 11 and Ubuntu 20.