1703327 - Select the right browser for import based on attribution

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Emily McMinn :emcminn]

As a followup to the Custom Chrome Messaging experiment, we have decided to update the import wizard to pre-select the browser to import from, based on new users' attribution data (where possible.)

Comment 1

[Punam Dahiya [:pdahiya]]

We might want to capture pre-select in our telemetry, it's not a blocker but good to implement in 89 if easy.

Comment 2

[Punam Dahiya [:pdahiya]]

Capturing proton onboarding import screen primary CTA label ask which could be a followup or implemented as part of this fix

primary button copy - Import from [previous browser]

If unable to detect name of previous browser,
button copy should be: Import from previous browser

Comment 3

[Emily McMinn :emcminn]

Attachment: Bug 1703327 - Get Attribution data on about:welcome import page

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0952d22ffd3e
Get Attribution data on about:welcome import page r=Mardak,pdahiya

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/0952d22ffd3e

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Hey emcminn, just a reminder to set the beta uplift flags if this is something we want to get into 89 for MR1. See https://docs.google.com/document/d/1HhxPXur_FyvidEn9UP85rHpQeLWp56JbaIulfdoc6AI/edit#.

Comment 7

[Emily McMinn :emcminn]

(In reply to Mike Conley (:mconley) (:⚙️) (Catching up on needinfos) from comment #6)

Hey emcminn, just a reminder to set the beta uplift flags if this is something we want to get into 89 for MR1. See https://docs.google.com/document/d/1HhxPXur_FyvidEn9UP85rHpQeLWp56JbaIulfdoc6AI/edit#.

Yep, Thanks for the reminder!

Comment 8

[Emily McMinn :emcminn]

Comment on attachment 9216525 [details]
Bug 1703327 - Get Attribution data on about:welcome import page

Beta/Release Uplift Approval Request

• User impact if declined: Required for MR1 / Proton - Import wizard will not correctly select previous browser.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: To test previous browser attribution:
  -download Firefox from Chrome
  -open about:welcome and navigate to the "import" screen and click "import from previous browser"
  -Observe the import wizard - the "chrome" option should be pre-selected.

To test RTAMO:

• in about:config, ensure browser.newtabpage.activity-stream.asrouter.devtoolsEnabled is set to "true"
  -open devtools by navigating to a new tab and clicking the wrench icon.
  -navigate to the "targeting" tab, and click "force attribution" at the bottom of the page, leaving the default values.
  -navigate to about:welcome; the RTAMO flow should now be displayed. (after refresh)

To test no attribution:
-on the targeting tab of newtab devtools, clear all the default values from the "force attribution" form, and click "force attribution"
-navigate to about:welcome; proton onboarding should be displayed.
-navigate to the import page and click "import from previous browser"
-observe the import wizard; the first option should be selected. (usually Edge on Windows, Safari on Mac).

• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): This patch touches code that determines default content for about:welcome based on attribution. (RTAMO, browser attribution, or no attribution).
• String changes made/needed: none

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9216525 [details]
Bug 1703327 - Get Attribution data on about:welcome import page

Approved for 89 beta 6, thanks.

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/b1df68271c9a

Comment 11

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement using the steps provided in comment 8 and I can confirm the following:

• The "Chrome" option is checked by default in the "Import Wizzard" if the browser attribution code is set to "chrome".
• The "RTAMO" flow is displayed if the "RTAMO" attribution parameters were forced from the "about:newtab#devtools>Targeting" page.
• The first option from the "Import Wizzard" is checked by default if there are no attribution parameters set at all.

Verified using the latest Firefox Nightly (90.0a1 Build ID - 20210428215523) installed on Windows 10 x64, Windows 8.1 x64, and Windows 7 x64.

Comment 12

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement using the steps provided in comment 8 and I can confirm the following:

• The "Chrome" option is checked by default in the "Import Wizard" if the browser attribution code is set to "chrome".
• The "RTAMO" flow is displayed if the "RTAMO" attribution parameters were forced from the "about:newtab#devtools>Targeting" page.
• The first option from the "Import Wizard" is checked by default if there are no attribution parameters set at all.

Verified using the latest Firefox Beta (89.0b7 Build ID - 20210502185943) installed on Windows 10 x64, Windows 8.1 x64, and Windows 7 x64.