1707140 - [win7] Remove theme screen from new user onboarding

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Ed Lee :Mardak]

To avoid bug 1702480, don't have new users pick a theme. With only a single step after the initial screen, maybe steps should be hidden?

Comment 1

[Ed Lee :Mardak]

We can reuse bug 1703327's prepareContentForReact to remove the theme screen

Comment 2

[Ed Lee :Mardak]

Attachment: Bug 1707140 - [win7] Remove theme screen from new user onboarding r?pdahiya

Use prepareContentForReact to remove any screen that uses theme tiles. Only show steps if there's more than 1 step.

Comment 3

[Ed Lee :Mardak]

Attachment: no steps

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66c7f635b562
[win7] Remove theme screen from new user onboarding r=pdahiya

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/66c7f635b562

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Ed, do you want to uplift it?

Comment 7

[Ed Lee :Mardak]

Comment on attachment 9218824 [details]
Bug 1707140 - [win7] Remove theme screen from new user onboarding r?pdahiya

Beta/Release Uplift Approval Request

• User impact if declined: New windows 7 users see a theme selection screen making bug 1702480 more common
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Go to about:welcome

2. See 2 screens (intro and import - no themes) and no step indicator

• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Slight behavior change removing 3rd screen for windows 7
• String changes made/needed: none

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9218824 [details]
Bug 1707140 - [win7] Remove theme screen from new user onboarding r?pdahiya

Mitigation for bug 1702480, with tests and a testing plan for QA, approved for 89 beta 8, thanks.

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/dfb9ab91b085

Comment 10

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement and I can confirm the "Themes" screen from the new users Onboarding page is no longer displayed.

Verified using the latest Firefox Nightly (90.0a1 - Build ID: 20210504092024) installed on Windows 7 x64.

Comment 11

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement and I can confirm the "Themes" screen from the new users Onboarding page is no longer displayed.

Verified using the latest Firefox Beta (89.0b8 - Build ID: 20210504185920) installed on Windows 7 x64.