1703692 - Intermittent browser/components/sessionstore/test/browser_formdata.js | Uncaught exception - at /browser/components/sessionstore/test/browser_formdata.js:48 - TypeError: can't access property 0, formdata.children is undefined

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect, P3)

Description

[Treeherder Bug Filer]

Filed by: apavel [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=335754150&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/MabWsanoRmitxAiqW8eDFg/runs/0/artifacts/public/logs/live_backing.log

---

[task 2021-04-07T21:18:18.594Z] 21:18:18     INFO - TEST-START | browser/components/sessionstore/test/browser_formdata.js
[task 2021-04-07T21:18:18.630Z] 21:18:18     INFO - GECKO(7216) | [Child 10565: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (7f254ae63c80) [pid = 10565] [serial = 1] [outer = 0] [url = http://example.com/]
[task 2021-04-07T21:18:18.630Z] 21:18:18     INFO - GECKO(7216) | [Child 10565: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 1 (7f2534992800) [pid = 10565] [serial = 2] [outer = 0] [url = about:blank]
[task 2021-04-07T21:18:18.630Z] 21:18:18     INFO - GECKO(7216) | [Child 10565: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 0 (7f2534999800) [pid = 10565] [serial = 3] [outer = 0] [url = http://example.com/]
[task 2021-04-07T21:18:18.630Z] 21:18:18     INFO - GECKO(7216) | [Child 10565, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/checkouts/gecko/xpcom/base/nsCycleCollector.cpp:3361
[task 2021-04-07T21:18:18.634Z] 21:18:18     INFO - GECKO(7216) | [Child 10565, Main Thread] WARNING: '!obs', file /builds/worker/checkouts/gecko/toolkit/components/sessionstore/RestoreTabContentObserver.cpp:58
[task 2021-04-07T21:18:18.635Z] 21:18:18     INFO - GECKO(7216) | [Child 10609: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7f608e299400 == 1 [pid = 10609] [id = 0]
[task 2021-04-07T21:18:18.636Z] 21:18:18     INFO - GECKO(7216) | [Child 10609: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 1 (7f60a4763c80) [pid = 10609] [serial = 1] [outer = 0]
[task 2021-04-07T21:18:18.638Z] 21:18:18     INFO - GECKO(7216) | [Child 10609: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 2 (7f608e29a400) [pid = 10609] [serial = 2] [outer = 7f60a4763c80]
[task 2021-04-07T21:18:18.680Z] 21:18:18     INFO - GECKO(7216) | [Child 10565, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:4442
[task 2021-04-07T21:18:18.803Z] 21:18:18     INFO - GECKO(7216) | [Child 9455: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (7fd43a919580) [pid = 9455] [serial = 26] [outer = 0] [url = about:newtab]
[task 2021-04-07T21:18:18.819Z] 21:18:18     INFO - GECKO(7216) | [Child 10609, Main Thread] WARNING: NS_ENSURE_TRUE(info) failed: file /builds/worker/checkouts/gecko/extensions/permissions/PermissionDelegateHandler.cpp:348
[task 2021-04-07T21:18:18.820Z] 21:18:18     INFO - GECKO(7216) | [Child 10609: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (7f60880b7400) [pid = 10609] [serial = 3] [outer = 7f60a4763c80]
[task 2021-04-07T21:18:18.904Z] 21:18:18     INFO - GECKO(7216) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpi4NiA6.mozrunner/runtests_leaks_tab_pid10697.log
[task 2021-04-07T21:18:18.905Z] 21:18:18     INFO - GECKO(7216) | [10697, Main Thread] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /builds/worker/checkouts/gecko/tools/profiler/core/platform.cpp:254
[task 2021-04-07T21:18:18.982Z] 21:18:18     INFO - GECKO(7216) | [Child 10697, Main Thread] WARNING: could not set real-time limit in CubebUtils::InitLibrary: file /builds/worker/checkouts/gecko/dom/media/CubebUtils.cpp:619
[task 2021-04-07T21:18:19.111Z] 21:18:19     INFO - GECKO(7216) | [Child 10609: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7f60880be800 == 2 [pid = 10609] [id = 1]
[task 2021-04-07T21:18:19.111Z] 21:18:19     INFO - GECKO(7216) | [Child 10609: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 4 (7f60a4763e40) [pid = 10609] [serial = 4] [outer = 0]
[task 2021-04-07T21:18:19.112Z] 21:18:19     INFO - GECKO(7216) | [Child 10609: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 5 (7f60880c0000) [pid = 10609] [serial = 5] [outer = 7f60a4763e40]
[task 2021-04-07T21:18:19.177Z] 21:18:19     INFO - GECKO(7216) | [Child 10614: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7f1e93c96400 == 1 [pid = 10614] [id = 0]
[task 2021-04-07T21:18:19.178Z] 21:18:19     INFO - GECKO(7216) | [Child 10614: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 1 (7f1eaa163c80) [pid = 10614] [serial = 1] [outer = 0]
[task 2021-04-07T21:18:19.179Z] 21:18:19     INFO - GECKO(7216) | [Child 10614: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 2 (7f1e93c97400) [pid = 10614] [serial = 2] [outer = 7f1eaa163c80]
[task 2021-04-07T21:18:19.218Z] 21:18:19     INFO - GECKO(7216) | [Child 10614: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (7f1e8dab6800) [pid = 10614] [serial = 3] [outer = 7f1eaa163c80]
[task 2021-04-07T21:18:19.420Z] 21:18:19     INFO - GECKO(7216) | [Child 10282: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 11 (7f0cea8a4800) [pid = 10282] [serial = 29] [outer = 0] [url = data:text/html;charset=utf-8,<iframe name=t src='data:text/html,A'></iframe><a id=lnk href='data:text/html,B' target=t>clickme</a><script>var i=document.createElement('iframe');i.setAttribute('src', 'data:text/html,C');document.body.appendChild(i);</script>]
[task 2021-04-07T21:18:19.420Z] 21:18:19     INFO - GECKO(7216) | [Child 10282: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 10 (7f0cea8a9400) [pid = 10282] [serial = 32] [outer = 0] [url = data:text/html,A]
[task 2021-04-07T21:18:19.420Z] 21:18:19     INFO - GECKO(7216) | [Child 10282: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 9 (7f0ceb6be400) [pid = 10282] [serial = 33] [outer = 0] [url = data:text/html,C]
[task 2021-04-07T21:18:19.420Z] 21:18:19     INFO - GECKO(7216) | [Child 10282: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 8 (7f0ceb6ca400) [pid = 10282] [serial = 34] [outer = 0] [url = data:text/html,B]
[task 2021-04-07T21:18:19.422Z] 21:18:19     INFO - GECKO(7216) | [Child 10282: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 7 (7f0ceb6ccc00) [pid = 10282] [serial = 39] [outer = 0] [url = about:blank]
[task 2021-04-07T21:18:19.425Z] 21:18:19     INFO - GECKO(7216) | [Child 10282: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 6 (7f0cea8a4c00) [pid = 10282] [serial = 38] [outer = 0] [url = about:blank]
[task 2021-04-07T21:18:19.425Z] 21:18:19     INFO - GECKO(7216) | [Child 10282: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (7f0cea8a1000) [pid = 10282] [serial = 36] [outer = 0] [url = about:blank]
[task 2021-04-07T21:18:19.426Z] 21:18:19     INFO - GECKO(7216) | [Child 10282: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7f0cea89c400 == 1 [pid = 10282] [id = 16] [url = about:blank]
[task 2021-04-07T21:18:19.502Z] 21:18:19     INFO - GECKO(7216) | [Child 10282: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (7f0cea807200) [pid = 10282] [serial = 40] [outer = 0] [url = about:blank]
[task 2021-04-07T21:18:19.503Z] 21:18:19     INFO - GECKO(7216) | [Child 10614: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7f1e8dabd800 == 2 [pid = 10614] [id = 1]
[task 2021-04-07T21:18:19.503Z] 21:18:19     INFO - GECKO(7216) | [Child 10614: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 4 (7f1e8d13f040) [pid = 10614] [serial = 4] [outer = 0]
[task 2021-04-07T21:18:19.510Z] 21:18:19     INFO - GECKO(7216) | [Child 10614: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 5 (7f1e8dabf000) [pid = 10614] [serial = 5] [outer = 7f1e8d13f040]
[task 2021-04-07T21:18:19.560Z] 21:18:19     INFO - GECKO(7216) | [Child 7280: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (7fb1feac5000) [pid = 7280] [serial = 333] [outer = 0] [url = about:blank]
[task 2021-04-07T21:18:19.576Z] 21:18:19     INFO - GECKO(7216) | [Child 7280: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7fb1feabd400 == 0 [pid = 7280] [id = 152] [url = about:blank]
[task 2021-04-07T21:18:19.654Z] 21:18:19     INFO - GECKO(7216) | updateSessionStoreFromTablistener() with aData.sHistoryNeeded, but no SHlistener. Add again!!!JavaScript error: resource:///modules/sessionstore/SessionStore.jsm, line 1091: Error: no SessionHistory object
[task 2021-04-07T21:18:19.654Z] 21:18:19     INFO - GECKO(7216) | [Parent 7216, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, mozilla::ipc::IPCResult::Ok()) failed with result 0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS): file /builds/worker/checkouts/gecko/dom/ipc/BrowserParent.cpp:2918
[task 2021-04-07T21:18:19.655Z] 21:18:19     INFO - TEST-INFO | started process screentopng
[task 2021-04-07T21:18:20.055Z] 21:18:20     INFO - TEST-INFO | screentopng: exit 0
[task 2021-04-07T21:18:20.055Z] 21:18:20     INFO - Buffered messages logged at 21:18:18
[task 2021-04-07T21:18:20.055Z] 21:18:20     INFO - Entering test bound test_formdata
[task 2021-04-07T21:18:20.055Z] 21:18:20     INFO - Buffered messages logged at 21:18:19
[task 2021-04-07T21:18:20.055Z] 21:18:20     INFO - TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | outer value is correct - 
[task 2021-04-07T21:18:20.055Z] 21:18:20     INFO - Buffered messages finished
[task 2021-04-07T21:18:20.055Z] 21:18:20     INFO - TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_formdata.js | Uncaught exception - at chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_formdata.js:48 - TypeError: can't access property 0, formdata.children is undefined
[task 2021-04-07T21:18:20.055Z] 21:18:20     INFO - Stack trace:
[task 2021-04-07T21:18:20.055Z] 21:18:20     INFO - test_formdata@chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_formdata.js:48:3
[task 2021-04-07T21:18:20.055Z] 21:18:20     INFO - Leaving test bound test_formdata```

Comment 1

[Intermittent Failures Robot]

17 failures in 3854 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 11
• mozilla-central: 4
• try: 2

Platform and build breakdown:

• linux1804-64: 17
  • debug: 17

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1703692&startday=2021-04-05&endday=2021-04-11&tree=all

Comment 2

[Intermittent Failures Robot]

30 failures in 4255 pushes (0.007 failures/push) were associated with this bug in the last 7 days.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 18
• try: 3
• mozilla-central: 9

Platform and build breakdown:

• linux1804-64: 27
  • debug: 27
• linux1804-64-shippable: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1703692&startday=2021-04-12&endday=2021-04-18&tree=all

Comment 3

[Intermittent Failures Robot]

17 failures in 3224 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 7
• mozilla-central: 10

Platform and build breakdown:

• linux1804-64: 11
  • debug: 11
• linux1804-64-shippable: 6
  • opt: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1703692&startday=2021-04-19&endday=2021-04-25&tree=all

Comment 4

[u608768]

Attachment: Bug 1703692 - Update test_formdata to also wait for the iframe load, r?annyG

Comment 5

[Intermittent Failures Robot]

20 failures in 3706 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 9
• mozilla-central: 10
• try: 1

Platform and build breakdown:

• linux1804-64: 18
  • debug: 18
• linux1804-64-shippable: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1703692&startday=2021-04-26&endday=2021-05-02&tree=all

Comment 6

[Intermittent Failures Robot]

32 failures in 3279 pushes (0.01 failures/push) were associated with this bug in the last 7 days.

This is the #44 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 17
• mozilla-central: 10
• try: 5

Platform and build breakdown:

• linux1804-64: 25
  • debug: 25
• linux1804-64-shippable: 7
  • opt: 7

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1703692&startday=2021-05-03&endday=2021-05-09&tree=all

Comment 7

[u608768]

The problem here is that we're checking the collected data before the subframe's nsFrameLoader::StartDestroy flush has finished. This has become more apparent with the patches from bug 1706445, and this will probably be fixed in that bug.

Comment 8

[Intermittent Failures Robot]

26 failures in 3061 pushes (0.008 failures/push) were associated with this bug in the last 7 days.

This is the #50 most frequent failure this week.

Repository breakdown:

• mozilla-central: 9
• autoland: 16
• try: 1

Platform and build breakdown:

• linux1804-64: 23
  • debug: 23
• linux1804-64-shippable: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1703692&startday=2021-05-17&endday=2021-05-23&tree=all

Comment 9

[Intermittent Failures Robot]

21 failures in 2908 pushes (0.007 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 7
• autoland: 10
• try: 4

Platform and build breakdown:

• linux1804-64: 19
  • debug: 19
• linux1804-64-shippable: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1703692&startday=2021-05-24&endday=2021-05-30&tree=all

Comment 10

[Intermittent Failures Robot]

15 failures in 3065 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 2
• autoland: 11
• try: 2

Platform and build breakdown:

• linux1804-64: 14
  • debug: 13
  • opt: 1
• linux1804-64-shippable: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1703692&startday=2021-05-31&endday=2021-06-06&tree=all

Comment 11

[u608768]

(In reply to :kashav from comment #7)

The problem here is that we're checking the collected data before the subframe's nsFrameLoader::StartDestroy flush has finished.

The problem is that we fail to get an owner element for subframe WindowGlobalParents when doing the final flush, and so we occasionally don't get an update for those frames. Might need to hold on to the owner element while a tab close flush is in progress.

Comment 12

[u608768]

So looks like we're racing between BrowserParent::ActorDestroy and non-toplevel WindowGlobalParent::RecvUpdateSessionStore. I wonder if it would be fine to wait for another event loop in BrowserChild::DelayedDeleteRunnable.

Comment 13

[u608768]

nika, any ideas for how to deal with this?

We're clearing BrowserParent::OwnerElement before we receive all flushes, so we sometimes don't have a frameElement here.

pernosco trace: https://pernos.co/debug/Bw0sExqwbOTU46w2I62xBA/index.html#f{m[Ahz8,AA_,t[AQ,CDs_,f{e[Ahz5,QxMo_,s{af6x3f5AA,bARY,uINHj,oIW5a___

Comment 14

[u608768]

Comment #13

Comment 15

[Nika Layzell [:nika] (ni? for response)]

I think the ideal fix in a situation like this is probably to avoid having sessionstore depending on the browser element itself, and instead depending on the BrowserId or similar, so that we don't need to worry about that particular attribute being cleared.

Potentially we can get away with some other fix here though, I suppose. What attributes are we needing from the <browser> itself? Could we get away with just keeping around the .permanentKey?

So looks like we're racing between BrowserParent::ActorDestroy and non-toplevel WindowGlobalParent::RecvUpdateSessionStore. I wonder if it would be fine to wait for another event loop in BrowserChild::DelayedDeleteRunnable.

That wouldn't help, as there's no guarantee of ordering between the toplevel BrowserChild instance and messages to any other process. If we want to handle this here, we have to deal with the BrowserParent::ActorDestroy already being called before we finish receiving sessionstore updates.

Comment 16

[Intermittent Failures Robot]

19 failures in 3502 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 4
• autoland: 12
• try: 3

Platform and build breakdown:

• linux1804-64: 19
  • debug: 16
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1703692&startday=2021-06-07&endday=2021-06-13&tree=all

Comment 17

[u608768]

Test is no longer failing, but I have an intermittent(?) Assertion failure: gc::IsCellPointerValid(obj): https://treeherder.mozilla.org/jobs?repo=try&revision=f0b2c7ac760a513e15cc4e17f7152395426bd3c1&selectedTaskRun=bP9hyZdPS5C-lmiy8nlWHw.0, and 1 sessionstore permafail: https://treeherder.mozilla.org/jobs?repo=try&revision=8b0256b3fb0ba8ab392a7c7c2641880721a4771b&selectedTaskRun=aG5WENNhQaey3ckbtVMsqA.0

Comment 18

[Intermittent Failures Robot]

22 failures in 774 pushes (0.028 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 19
• mozilla-central: 3

Platform and build breakdown:

• linux1804-64: 9
  • debug: 7
  • opt: 2
• linux1804-64-asan: 12
  • opt: 12
• linux1804-64-shippable: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1703692&startday=2021-06-17&endday=2021-06-17&tree=all

Comment 19

[Intermittent Failures Robot]

54 failures in 2888 pushes (0.019 failures/push) were associated with this bug in the last 7 days.

This is the #20 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 45
• try: 1
• mozilla-central: 8

Platform and build breakdown:

• linux1804-64: 27
  • opt: 12
  • debug: 15
• linux1804-64-shippable: 5
  • opt: 5
• linux1804-64-asan: 22
  • opt: 22

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1703692&startday=2021-06-14&endday=2021-06-20&tree=all

Comment 20

[u608768]

Attachment: Bug 1703692 - Use ChildOffset to build the offset path for flushes, r?nika

This makes it so we don't have to rely on the context chain being available at
flush time, which was one of the reasons that we were dropping shutdown updates.

Comment 21

[u608768]

Attachment: Bug 1703692 - Store the latest embedder's permanent key on CanonicalBrowsingContext, r?nika

And include it in Session Store flushes to avoid dropping updates in case the
browser is unavailable.

Comment 22

[u608768]

Attachment: Bug 1703692 - Update SessionStore and TabState{,Cache} functions to take a permanentKey, r?nika

Depends on D118385

Comment 23

[Intermittent Failures Robot]

19 failures in 640 pushes (0.03 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 19

Platform and build breakdown:

• linux1804-64: 6
  • opt: 5
  • debug: 1
• linux1804-64-asan: 12
  • opt: 12
• android-em-7-0-x86_64-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1703692&startday=2021-06-22&endday=2021-06-22&tree=all

Comment 24

[Intermittent Failures Robot]

15 failures in 649 pushes (0.023 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 13
• mozilla-central: 2

Platform and build breakdown:

• linux1804-64-shippable: 1
  • opt: 1
• linux1804-64-asan: 8
  • opt: 8
• macosx1015-64-qr: 1
  • debug: 1
• linux1804-64: 5
  • opt: 3
  • debug: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1703692&startday=2021-06-23&endday=2021-06-23&tree=all

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14fe807e6be4
Store the latest embedder's permanent key on CanonicalBrowsingContext, r=nika,mccr8
https://hg.mozilla.org/integration/autoland/rev/599a0a99ded9
Update SessionStore and TabState{,Cache} functions to take a permanentKey, r=nika
https://hg.mozilla.org/integration/autoland/rev/a199dfd8ce8d
Use ChildOffset to build the offset path for flushes, r=nika

Comment 26

[Iulian Moraru]

Backed out for causing bc failures on multiple files.

Push with failures

Failure log
Failure log
Failure log

Backout link

Comment 27

[u608768]

Forgot to clear mPermanentKey on Discard.

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6745b363a745
Store the latest embedder's permanent key on CanonicalBrowsingContext, r=nika,mccr8
https://hg.mozilla.org/integration/autoland/rev/eec4a4138ca7
Update SessionStore and TabState{,Cache} functions to take a permanentKey, r=nika
https://hg.mozilla.org/integration/autoland/rev/fe5703d7b580
Use ChildOffset to build the offset path for flushes, r=nika

Comment 29

[Intermittent Failures Robot]

15 failures in 515 pushes (0.029 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• autoland: 14
• mozilla-central: 1

Platform and build breakdown:

• linux1804-64-asan: 11
  • opt: 11
• linux1804-64: 2
  • opt: 1
  • debug: 1
• linux1804-64-shippable: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1703692&startday=2021-06-25&endday=2021-06-25&tree=all

Comment 30

[Dorel Luca [:dluca]]

Backed out 3 changesets (bug 1703692) for Browser-chrome failures in browser/components/sessionstore/test/browser_broadcast.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=343922904&repo=autoland&lineNumber=2974

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=fe5703d7b580d42ac83e294454b46a36c5cf0989

Backout:
https://hg.mozilla.org/integration/autoland/rev/52d22482d72df9cc71a71c2984f579434ba2c828

Comment 31

[u608768]

Attachment: WIP: Bug 1703692 - Clear mPermanentKey after the shutdown flushes complete,

Depends on D118384

Comment 32

[u608768]

New patch fixes the leaks from comment #26. Clearing on Discard doesn't work because we may be flushing after a discard.

Comment 33

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d66254ef407
Store the latest embedder's permanent key on CanonicalBrowsingContext, r=nika,mccr8
https://hg.mozilla.org/integration/autoland/rev/6bcbb0959a72
Update SessionStore and TabState{,Cache} functions to take a permanentKey, r=nika
https://hg.mozilla.org/integration/autoland/rev/3f9e98489ae5
Use ChildOffset to build the offset path for flushes, r=nika

Comment 34

[Andreea Pavel [:apavel]]

There are 88 total failures in the last 7 days on

• linux1804-64 debug and opt
• linux1804-64-asan opt
• linux1804-64-shippable opt

Recent failure log: https://treeherder.mozilla.org/logviewer?job_id=343946582&repo=autoland&lineNumber=3860

[task 2021-06-26T15:34:50.465Z] 15:34:50 INFO - TEST-START | browser/components/sessionstore/test/browser_formdata.js
[task 2021-06-26T15:34:51.903Z] 15:34:51 INFO - TEST-INFO | started process screentopng
[task 2021-06-26T15:34:52.643Z] 15:34:52 INFO - TEST-INFO | screentopng: exit 0
[task 2021-06-26T15:34:52.644Z] 15:34:52 INFO - Buffered messages logged at 15:34:50
[task 2021-06-26T15:34:52.644Z] 15:34:52 INFO - Entering test bound test_formdata
[task 2021-06-26T15:34:52.644Z] 15:34:52 INFO - Buffered messages logged at 15:34:51
[task 2021-06-26T15:34:52.644Z] 15:34:52 INFO - TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | outer value is correct -
[task 2021-06-26T15:34:52.645Z] 15:34:52 INFO - Buffered messages finished
[task 2021-06-26T15:34:52.647Z] 15:34:52 INFO - TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_formdata.js | Uncaught exception - at chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_formdata.js:48 - TypeError: can't access property 0, formdata.children is undefined
[task 2021-06-26T15:34:52.647Z] 15:34:52 INFO - Stack trace:
[task 2021-06-26T15:34:52.648Z] 15:34:52 INFO - test_formdata@chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_formdata.js:48:3
[task 2021-06-26T15:34:52.652Z] 15:34:52 INFO - Leaving test bound test_formdata
[task 2021-06-26T15:34:52.652Z] 15:34:52 INFO - Entering test bound test_url_check
[task 2021-06-26T15:34:52.652Z] 15:34:52 INFO - GECKO(1557) | ###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
[task 2021-06-26T15:34:52.654Z] 15:34:52 INFO - GECKO(1557) | ###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
[task 2021-06-26T15:34:52.655Z] 15:34:52 INFO - GECKO(1557) | -----------------------------------------------------
[task 2021-06-26T15:34:52.655Z] 15:34:52 INFO - GECKO(1557) | Suppressions used:
[task 2021-06-26T15:34:52.658Z] 15:34:52 INFO - GECKO(1557) | count bytes template
[task 2021-06-26T15:34:52.658Z] 15:34:52 INFO - GECKO(1557) | 14 448 nsComponentManagerImpl
[task 2021-06-26T15:34:52.659Z] 15:34:52 INFO - GECKO(1557) | 2 288 libfontconfig.so
[task 2021-06-26T15:34:52.659Z] 15:34:52 INFO - GECKO(1557) | -----------------------------------------------------
[task 2021-06-26T15:34:52.660Z] 15:34:52 INFO - GECKO(1557) | ###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
[task 2021-06-26T15:34:52.999Z] 15:34:52 INFO - TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | form data restored -
[task 2021-06-26T15:34:53.133Z] 15:34:53 INFO - TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | form data not restored -
[task 2021-06-26T15:34:53.246Z] 15:34:53 INFO - TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | form data not restored -
[task 2021-06-26T15:34:53.265Z] 15:34:53 INFO - Leaving test bound test_url_check
[task 2021-06-26T15:34:53.266Z] 15:34:53 INFO - Entering test bound test_nested
[task 2021-06-26T15:34:53.976Z] 15:34:53 INFO - GECKO(1557) | -----------------------------------------------------
[task 2021-06-26T15:34:53.977Z] 15:34:53 INFO - GECKO(1557) | Suppressions used:
[task 2021-06-26T15:34:53.978Z] 15:34:53 INFO - GECKO(1557) | count bytes template
[task 2021-06-26T15:34:53.979Z] 15:34:53 INFO - GECKO(1557) | 14 448 nsComponentManagerImpl
[task 2021-06-26T15:34:53.979Z] 15:34:53 INFO - GECKO(1557) | 2 288 libfontconfig.so
[task 2021-06-26T15:34:53.980Z] 15:34:53 INFO - GECKO(1557) | -----------------------------------------------------
[task 2021-06-26T15:34:54.272Z] 15:34:54 INFO - GECKO(1557) | -----------------------------------------------------
[task 2021-06-26T15:34:54.272Z] 15:34:54 INFO - GECKO(1557) | Suppressions used:
[task 2021-06-26T15:34:54.272Z] 15:34:54 INFO - GECKO(1557) | count bytes template
[task 2021-06-26T15:34:54.272Z] 15:34:54 INFO - GECKO(1557) | 14 448 nsComponentManagerImpl
[task 2021-06-26T15:34:54.272Z] 15:34:54 INFO - GECKO(1557) | 2 288 libfontconfig.so
[task 2021-06-26T15:34:54.272Z] 15:34:54 INFO - GECKO(1557) | -----------------------------------------------------
[task 2021-06-26T15:34:55.203Z] 15:34:55 INFO - TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | formdata for iframe stored correctly -
[task 2021-06-26T15:34:55.453Z] 15:34:55 INFO - TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | formdata for iframe restored correctly -
[task 2021-06-26T15:34:55.470Z] 15:34:55 INFO - Leaving test bound test_nested
[task 2021-06-26T15:34:55.472Z] 15:34:55 INFO - Entering test bound test_design_mode
[task 2021-06-26T15:34:56.134Z] 15:34:56 INFO - TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | editable document has been restored correctly -
[task 2021-06-26T15:34:56.387Z] 15:34:56 INFO - TEST-PASS | browser/components/sessionstore/test/browser_formdata.js | editable document has been restored correctly -
[task 2021-06-26T15:34:56.425Z] 15:34:56 INFO - Leaving test bound test_design_mode
[task 2021-06-26T15:34:56.463Z] 15:34:56 INFO - GECKO(1557) | MEMORY STAT | vsize 20983646MB | residentFast 1547MB
[task 2021-06-26T15:34:56.465Z] 15:34:56 INFO - TEST-OK | browser/components/sessionstore/test/browser_formdata.js | took 6001ms
[task 2021-06-26T15:34:56.499Z] 15:34:56 INFO - checking window state

Comment 35

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4d66254ef407
https://hg.mozilla.org/mozilla-central/rev/6bcbb0959a72
https://hg.mozilla.org/mozilla-central/rev/3f9e98489ae5

Comment 36

[Intermittent Failures Robot]

80 failures in 3115 pushes (0.026 failures/push) were associated with this bug in the last 7 days.

This is the #13 most frequent failure this week.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• autoland: 73
• mozilla-central: 6
• try: 1

Platform and build breakdown:

• linux1804-64-asan: 51
  • opt: 51
• linux1804-64: 22
  • debug: 8
  • opt: 14
• android-em-7-0-x86_64-qr: 1
  • opt: 1
• linux1804-64-shippable: 5
  • opt: 5
• macosx1015-64-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1703692&startday=2021-06-21&endday=2021-06-27&tree=all