1706445 - Remove the "SessionStore:update" and "SessionStore:flush" messages for SHIP

Status: RESOLVED FIXED

(Firefox :: Session Restore, task, P2)

Description

[u608768]

These are used to send frame data to the parent.

• https://searchfox.org/mozilla-central/rev/9b430bb1a11d7152cab2af4574f451ffb906b052/browser/components/sessionstore/TabStateFlusher.jsm#124
• https://searchfox.org/mozilla-central/rev/9b430bb1a11d7152cab2af4574f451ffb906b052/browser/components/sessionstore/ContentSessionStore.jsm#485

With SHIP, the update messages don't actually have any useful information except for the flushID (to know which TabStateFlusher promise to resolve) and the isFinal bit (for cleanup after a frame is unloaded), but it shouldn't be too hard to get that information into SessionStore in other ways.

Comment 2

[u608768]

Latest patch has 1 try-only permafail (browser_formdata_cc.js) and 2 try-only intermittents (browser_sessionHistory.js, browser_formdata.js). Looking forward to debugging those next week.

Still need to update the uses of "SessionStore:update" in talos.

Comment 3

[u608768]

Attachment: Bug 1706445 - Remove the "SessionStore:update" and "SessionStore:flush" messages for SHIP, r?nika

For TabStateFlusher.flush() calls:
We now just resolve the TabStateFlusher.flush() promise immediately after the
native nsFrameLoader::RequestTabStateFlush promise resolves. This is fine
because SessionStore will have seen all tab state updates by this point. The
non-SHIP code still waits for the ContentSessionStore round trip.

For the final "SessionStore:update" (sent by the frame script on unload):
This still piggybacks on the somewhat-flaky tab state flush triggered by
nsFrameLoader::StartDestroy. To ensure we're only cleaning up SessionStore
state after we've received updates from all frames in the tree, SessionStore
tracks the number of isFinal updates it receives and only proceeds when
appropriate.

This also stops loading the content-sessionStore.js frame script for SHIP.

Comment 4

[u608768]

Attachment: Bug 1706445 - Fix test helpers that use "SessionStore:update", r?nika

Updates some test helpers to use the "SSTabStateFinalUpdate" event instead of
the isFinal "SessionStore:update" frame script message, and skips a frame script
OOM test for Fission.

Depends on D115929

Comment 5

[u608768]

Attachment: Bug 1706445 - Stop using "SessionStore:flush" for SHIP, r?nika

Comment 6

[u608768]

Attachment: Bug 1706445 - Merge the two TabState.update() paths, r?nika

This will make it easier to handle isFinal updates.

Depends on D116144

Comment 7

[u608768]

Attachment: Bug 1706445 - Handle `isFinal` updates through native code, r?nika

Depends on D116145

Comment 8

[u608768]

Attachment: Bug 1706445 - Stop loading content-sessionStore.js for SHIP, r?nika

Depends on D116146

Comment 9

[u608768]

Attachment: Bug 1706445 - Only expect ContentSessionStore.jsm to load without Fission, r?gijs

We'll stop loading content-sessionStore.js for Fission in D116147.

Depends on D115930

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/279ab2402566
Stop using "SessionStore:flush" for SHIP, r=nika
https://hg.mozilla.org/integration/autoland/rev/6b8520fb2bba
Merge the two TabState.update() paths, r=nika
https://hg.mozilla.org/integration/autoland/rev/6b4440c599e1
Handle `isFinal` updates through native code, r=nika
https://hg.mozilla.org/integration/autoland/rev/4e393ab22e60
Stop loading content-sessionStore.js for SHIP, r=nika
https://hg.mozilla.org/integration/autoland/rev/bf1815778af2
Fix test helpers that use "SessionStore:update", r=nika,perftest-reviewers,sparky
https://hg.mozilla.org/integration/autoland/rev/b607c8868333
Only expect ContentSessionStore.jsm to load without Fission, r=Gijs

Comment 11

[u608768]

Attachment: WIP: Bug 1706445 - Fix for D116146

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2852817a4061
WIP: Bug 1706445 - Fix for D116146 r=annyG

Comment 13

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/279ab2402566
https://hg.mozilla.org/mozilla-central/rev/6b8520fb2bba
https://hg.mozilla.org/mozilla-central/rev/6b4440c599e1
https://hg.mozilla.org/mozilla-central/rev/4e393ab22e60
https://hg.mozilla.org/mozilla-central/rev/bf1815778af2
https://hg.mozilla.org/mozilla-central/rev/b607c8868333
https://hg.mozilla.org/mozilla-central/rev/2852817a4061